Skip to content

chore: replace workspace:^ with static versions in example apps#1261

Merged
joker23 merged 3 commits into
mainfrom
devin/1775831039-sdk-2157-replace-workspace-versions
Apr 10, 2026
Merged

chore: replace workspace:^ with static versions in example apps#1261
joker23 merged 3 commits into
mainfrom
devin/1775831039-sdk-2157-replace-workspace-versions

Conversation

@joker23

@joker23 joker23 commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions

No test changes needed — this only affects example app dependency declarations and release-please configuration.

Related issues

SDK-2157

Describe the solution you've provided

Replaces all workspace:^ references for @launchdarkly/* dependencies in example app package.json files with their current static versions from .release-please-manifest.json (or the package's own package.json for electron/svelte which are not yet in the manifest).

Adds extra-files entries to release-please-config.json so these versions are automatically bumped on future releases.

Affected example apps (12 files):

  • packages/sdk/browser/example and example-fdv2@launchdarkly/js-client-sdk 4.4.1
  • packages/sdk/electron/example@launchdarkly/electron-client-sdk 0.0.1
  • packages/sdk/react-native/example@launchdarkly/react-native-client-sdk 10.15.1
  • packages/sdk/svelte/example@launchdarkly/svelte-client-sdk 0.1.0
  • 7 server-ai examples (openai, bedrock, vercel-ai, tracked-chat, chat-judge, direct-judge, chat-observability) → static versions for node-server-sdk, server-sdk-ai, and the relevant AI provider packages

release-please-config.json changes:

  • Added extra-files to existing entries: browser, react-native, server-node, server-ai, server-ai-openai, server-ai-vercel, server-ai-langchain
  • Added new entries for packages/sdk/electron and packages/sdk/svelte (not yet in the release-please manifest — entries will take effect once those packages join the release pipeline)
  • Cross-package references (e.g., server-ai examples depending on node-server-sdk) use absolute paths from repo root, following the existing server-nodereact-server-example pattern

Describe alternatives you've considered

N/A — this follows the established pattern already used by cloudflare, fastly, akamai-base, akamai-edgekv, and react example apps.

Additional context

Human review checklist

  • Verify the static versions match current published versions (sourced from .release-please-manifest.json)
  • Confirm extra-files jsonpath expressions match the actual dependency key names in each example's package.json
  • Confirm that adding packages/sdk/electron and packages/sdk/svelte to release-please-config.json won't cause issues before those packages are added to the manifest
  • Verify cross-package extra-files use absolute paths (/packages/...) while same-package entries use relative paths

Link to Devin session: https://app.devin.ai/sessions/c56e3cf1d5e84389a79b9e3f818605c4
Requested by: @joker23


Note

Low Risk
Low risk since changes are limited to example-app dependency version pinning and release-please config updates; main risk is misconfigured jsonpath/paths causing future automated bumps to miss or update the wrong fields.

Overview
Pins previously workspace:^ LaunchDarkly dependencies in multiple example apps (browser, Electron, React Native, Svelte, and several server-ai examples) to specific published versions.

Updates release-please-config.json to add extra-files entries (and new package sections for packages/sdk/electron and packages/sdk/svelte) so future releases automatically bump the corresponding dependency versions in these example package.json files, including cross-package references like @launchdarkly/node-server-sdk used by the server-ai examples.

Reviewed by Cursor Bugbot for commit dfac6c5. Bugbot is set up for automated code reviews on this repo. Configure here.


Open with Devin

Replace workspace:^ references with static versions in all example
app package.json files and add release-please extra-files entries
to keep them updated on future releases.

Ref: SDK-2157
Co-Authored-By: Steven Zhang <szhang@launchdarkly.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@devin-ai-integration

Copy link
Copy Markdown
Contributor

@cursor review

@github-actions

Copy link
Copy Markdown
Contributor

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 25661 bytes
Compressed size limit: 29000
Uncompressed size: 126143 bytes

@github-actions

Copy link
Copy Markdown
Contributor

@launchdarkly/browser size report
This is the brotli compressed size of the ESM build.
Compressed size: 179348 bytes
Compressed size limit: 200000
Uncompressed size: 830127 bytes

@github-actions

Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Compressed size: 31736 bytes
Compressed size limit: 34000
Uncompressed size: 112937 bytes

@github-actions

Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 37181 bytes
Compressed size limit: 38000
Uncompressed size: 204409 bytes

@joker23

joker23 commented Apr 10, 2026

Copy link
Copy Markdown
Contributor Author

@cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 1e5d2f0. Configure here.

@joker23 joker23 marked this pull request as ready for review April 10, 2026 14:51
@joker23 joker23 requested a review from a team as a code owner April 10, 2026 14:51
devin-ai-integration[bot]

This comment was marked as resolved.

Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
devin-ai-integration[bot]

This comment was marked as resolved.

Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@joker23 joker23 merged commit f74ead6 into main Apr 10, 2026
46 checks passed
@joker23 joker23 deleted the devin/1775831039-sdk-2157-replace-workspace-versions branch April 10, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants