chore: replace workspace:^ with static versions in example apps#1261
Conversation
Replace workspace:^ references with static versions in all example app package.json files and add release-please extra-files entries to keep them updated on future releases. Ref: SDK-2157 Co-Authored-By: Steven Zhang <szhang@launchdarkly.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
@cursor review |
|
@launchdarkly/js-sdk-common size report |
|
@launchdarkly/browser size report |
|
@launchdarkly/js-client-sdk size report |
|
@launchdarkly/js-client-sdk-common size report |
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 1e5d2f0. Configure here.
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Requirements
No test changes needed — this only affects example app dependency declarations and release-please configuration.
Related issues
SDK-2157
Describe the solution you've provided
Replaces all
workspace:^references for@launchdarkly/*dependencies in example apppackage.jsonfiles with their current static versions from.release-please-manifest.json(or the package's ownpackage.jsonfor electron/svelte which are not yet in the manifest).Adds
extra-filesentries torelease-please-config.jsonso these versions are automatically bumped on future releases.Affected example apps (12 files):
packages/sdk/browser/exampleandexample-fdv2→@launchdarkly/js-client-sdk4.4.1packages/sdk/electron/example→@launchdarkly/electron-client-sdk0.0.1packages/sdk/react-native/example→@launchdarkly/react-native-client-sdk10.15.1packages/sdk/svelte/example→@launchdarkly/svelte-client-sdk0.1.0node-server-sdk,server-sdk-ai, and the relevant AI provider packagesrelease-please-config.json changes:
browser,react-native,server-node,server-ai,server-ai-openai,server-ai-vercel,server-ai-langchainpackages/sdk/electronandpackages/sdk/svelte(not yet in the release-please manifest — entries will take effect once those packages join the release pipeline)node-server-sdk) use absolute paths from repo root, following the existingserver-node→react-server-examplepatternDescribe alternatives you've considered
N/A — this follows the established pattern already used by cloudflare, fastly, akamai-base, akamai-edgekv, and react example apps.
Additional context
Human review checklist
.release-please-manifest.json)extra-filesjsonpath expressions match the actual dependency key names in each example'spackage.jsonpackages/sdk/electronandpackages/sdk/sveltetorelease-please-config.jsonwon't cause issues before those packages are added to the manifest/packages/...) while same-package entries use relative pathsLink to Devin session: https://app.devin.ai/sessions/c56e3cf1d5e84389a79b9e3f818605c4
Requested by: @joker23
Note
Low Risk
Low risk since changes are limited to example-app dependency version pinning and
release-pleaseconfig updates; main risk is misconfiguredjsonpath/paths causing future automated bumps to miss or update the wrong fields.Overview
Pins previously
workspace:^LaunchDarkly dependencies in multiple example apps (browser, Electron, React Native, Svelte, and severalserver-aiexamples) to specific published versions.Updates
release-please-config.jsonto addextra-filesentries (and new package sections forpackages/sdk/electronandpackages/sdk/svelte) so future releases automatically bump the corresponding dependency versions in these examplepackage.jsonfiles, including cross-package references like@launchdarkly/node-server-sdkused by theserver-aiexamples.Reviewed by Cursor Bugbot for commit dfac6c5. Bugbot is set up for automated code reviews on this repo. Configure here.