chore: remove stale eslint-disable comments#1300
Merged
Merged
Conversation
Remove ~65 eslint-disable comments for rules that no longer exist after replacing eslint-config-airbnb-base with eslint:recommended: - no-param-reassign (43 comments) - no-bitwise (10 comments) - no-restricted-syntax for ForOfStatement (11 comments) - no-plusplus (4 comments) - no-continue (1 comment) Retains a targeted no-restricted-syntax disable in vendor TraceKit.ts for a legitimate for...in loop. No functional code changes. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
joker23
force-pushed
the
skz/sdk-2219/eslint-comments
branch
from
922523f to
5526f0a
Compare
Contributor
|
@launchdarkly/js-sdk-common size report |
Contributor
|
@launchdarkly/js-client-sdk size report |
Contributor
|
@launchdarkly/browser size report |
Contributor
|
@launchdarkly/js-client-sdk-common size report |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Add no-param-reassign back as an explicit rule (was previously provided by airbnb). Restore the existing eslint-disable comments in files that intentionally reassign parameters. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
kinyoklion
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eslint-disablecomments for rules that no longer exist after replacing airbnb configno-param-reassign(43),no-bitwise(10),no-restricted-syntaxfor ForOfStatement (11),no-plusplus(4),no-continue(1)no-restricted-syntaxdisable in vendorTraceKit.tsfor a legitimatefor...inloopTest plan
yarn workspaces foreach -p run lintpasses with 0 errorsgrep -rn "eslint-disable.*no-(param-reassign|bitwise|plusplus|continue)" packages/returns zero resultsDepends on #1299.
🤖 Generated with Claude Code
Note
Low Risk
Primarily removes lint suppression comments with no runtime behavior changes; minor risk is limited to new
no-param-reassignenforcement surfacing previously ignored lint violations.Overview
Cleans up stale
eslint-disabledirectives across SDKs/tests (bitwise, plusplus, restricted-syntax, etc.) after the eslint config change, leaving code behavior unchanged.Updates
.eslintrc.jsto explicitly enforceno-param-reassign, and keeps a single targetedno-restricted-syntaxsuppression in vendorTraceKit.tsfor a necessaryfor...inloop.Reviewed by Cursor Bugbot for commit 7695809. Bugbot is set up for automated code reviews on this repo. Configure here.