Conversation
f87a58e to
df6cb7d
Compare
|
@launchdarkly/js-sdk-common size report |
|
@launchdarkly/js-client-sdk size report |
|
@launchdarkly/js-client-sdk-common size report |
|
@launchdarkly/browser size report |
|
@cursor review |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit df6cb7d. Configure here.
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "extends": "./.svelte-kit/tsconfig.json", | |||
| "extends": "./tsconfig.eslint.json", | |||
There was a problem hiding this comment.
Svelte tsconfig.json extends wrong base config file
High Severity
The tsconfig.json now extends ./tsconfig.eslint.json instead of ./.svelte-kit/tsconfig.json. The .svelte-kit/tsconfig.json is generated by SvelteKit (via svelte-kit sync) and contains critical path aliases (like $lib, $app) and other settings required for proper TypeScript compilation and IDE support. The tsconfig.eslint.json is a simplified config intended only for ESLint's TypeScript parser. This change breaks the SvelteKit TypeScript integration for builds and IDE tooling.
Reviewed by Cursor Bugbot for commit df6cb7d. Configure here.


This PR will update eslint to version 9 with the following changes:
eslint.config.mjsAs a result, there are some deprecated/updated recommendations. In general, I tried to go with the recommendations as much as possible, the deviations and notible changes are:
no-redeclarerule is deprecated because typescript compilers should catch these cases nowexplicit-anyis disabled for now because we have too many violationsno-param-reassignis a bit more permissible than before - now, it will let object field modifications but not whole value replacements.max-classes-per-fileis not re-enabled (recommendations did not enable it)class-method-use-thisis off due to too many violationsI did not include any style rules as those will be introduced in a separate PR.
Note
Medium Risk
Repo-wide linting behavior changes due to ESLint v9 + new flat config, which can cause new/removed lint failures across many packages even though runtime logic changes are minimal.
Overview
Upgrades linting across the monorepo to ESLint v9 and migrates from legacy
.eslintrc/.eslintignoreto a single flat config ineslint.config.mjs, including consolidated ignore patterns, TypeScript project parsing, import resolution, and test/example-specific overrides.Updates root and package
lintscripts/dependencies to use the new ESLint v9 ecosystem (@eslint/js,typescript-eslint,eslint-plugin-import-x,globals,eslint-import-resolver-typescript) and removes now-unneeded package-level ESLint configs/overrides.Applies follow-up code tweaks to satisfy new rules/recommendations (mostly removing/adjusting
eslint-disablecomments, adding targeted disables forno-await-in-loop/no-use-before-define, and updating a few rule-specific disables likeno-empty-object-type).Reviewed by Cursor Bugbot for commit df6cb7d. Bugbot is set up for automated code reviews on this repo. Configure here.