From e1afdd0e20ef14f437993fd4564122e209317a94 Mon Sep 17 00:00:00 2001
From: Matthew Keeler <mkeeler@launchdarkly.com>
Date: Thu, 30 Apr 2026 11:06:03 -0400
Subject: [PATCH] fix(common): remove non-spec fields from GoodbyeObject

The FDv2 goodbye event only carries a reason field. The GoodbyeObject
interface incorrectly declared silent and catastrophe properties; the
runtime protocol handler already only reads reason, so this is a
type-only cleanup. Test fixtures that included the extra fields are
updated to match the spec.
---
 packages/shared/common/src/internal/fdv2/proto.ts             | 2 --
 .../sdk-client/__tests__/datasource/fdv2/PollingBase.test.ts  | 2 +-
 .../__tests__/datasource/fdv2/PollingInitializer.test.ts      | 2 +-
 .../__tests__/datasource/fdv2/StreamingFDv2Base.test.ts       | 4 ----
 4 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/packages/shared/common/src/internal/fdv2/proto.ts b/packages/shared/common/src/internal/fdv2/proto.ts
index 3701c8717e..f7acd03d24 100644
--- a/packages/shared/common/src/internal/fdv2/proto.ts
+++ b/packages/shared/common/src/internal/fdv2/proto.ts
@@ -66,8 +66,6 @@ export interface DeleteObject {
 
 export interface GoodbyeObject {
   reason: string;
-  silent: boolean;
-  catastrophe: boolean;
 }
 
 export interface ErrorObject {
diff --git a/packages/shared/sdk-client/__tests__/datasource/fdv2/PollingBase.test.ts b/packages/shared/sdk-client/__tests__/datasource/fdv2/PollingBase.test.ts
index bed44e1eb5..1b17f380fd 100644
--- a/packages/shared/sdk-client/__tests__/datasource/fdv2/PollingBase.test.ts
+++ b/packages/shared/sdk-client/__tests__/datasource/fdv2/PollingBase.test.ts
@@ -286,7 +286,7 @@ describe('given a goodbye event in the response', () => {
       },
       {
         event: 'goodbye',
-        data: { reason: 'server-shutdown', silent: false, catastrophe: false },
+        data: { reason: 'server-shutdown' },
       },
     ]);
     const requestor = makeRequestor({
diff --git a/packages/shared/sdk-client/__tests__/datasource/fdv2/PollingInitializer.test.ts b/packages/shared/sdk-client/__tests__/datasource/fdv2/PollingInitializer.test.ts
index d53f29fb9c..b17510630c 100644
--- a/packages/shared/sdk-client/__tests__/datasource/fdv2/PollingInitializer.test.ts
+++ b/packages/shared/sdk-client/__tests__/datasource/fdv2/PollingInitializer.test.ts
@@ -174,7 +174,7 @@ it('does not retry on goodbye result', async () => {
     },
     {
       event: 'goodbye',
-      data: { reason: 'server-shutdown', silent: false, catastrophe: false },
+      data: { reason: 'server-shutdown' },
     },
   ]);
   const requestor: FDv2Requestor = {
diff --git a/packages/shared/sdk-client/__tests__/datasource/fdv2/StreamingFDv2Base.test.ts b/packages/shared/sdk-client/__tests__/datasource/fdv2/StreamingFDv2Base.test.ts
index 33086a5bb4..cc45e8577a 100644
--- a/packages/shared/sdk-client/__tests__/datasource/fdv2/StreamingFDv2Base.test.ts
+++ b/packages/shared/sdk-client/__tests__/datasource/fdv2/StreamingFDv2Base.test.ts
@@ -125,8 +125,6 @@ it('produces a goodbye status result', async () => {
 
   simulateEvent(mockEventSource, 'goodbye', {
     reason: 'server restarting',
-    silent: false,
-    catastrophe: false,
   });
 
   const result = await base.takeResult();
@@ -416,8 +414,6 @@ it('produces results in order', async () => {
 
   simulateEvent(mockEventSource, 'goodbye', {
     reason: 'bye',
-    silent: false,
-    catastrophe: false,
   });
 
   const r1 = await base.takeResult();