Skip to content

fix(common): remove non-spec fields from FDv2 GoodbyeObject #1341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
keelerm84 merged 1 commit into from
Apr 30, 2026
Merged

fix(common): remove non-spec fields from FDv2 GoodbyeObject #1341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions packages/shared/common/src/internal/fdv2/proto.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,6 @@ export interface DeleteObject {

export interface GoodbyeObject {
reason: string;
silent: boolean;
catastrophe: boolean;
}

export interface ErrorObject {
Expand Down
2 changes: 1 addition & 1 deletion packages/shared/sdk-client/__tests__/datasource/fdv2/PollingBase.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ describe('given a goodbye event in the response', () => {
},
{
event: 'goodbye',
data: { reason: 'server-shutdown', silent: false, catastrophe: false },
data: { reason: 'server-shutdown' },
},
]);
const requestor = makeRequestor({
Expand Down
2 changes: 1 addition & 1 deletion packages/shared/sdk-client/__tests__/datasource/fdv2/PollingInitializer.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ it('does not retry on goodbye result', async () => {
},
{
event: 'goodbye',
data: { reason: 'server-shutdown', silent: false, catastrophe: false },
data: { reason: 'server-shutdown' },
},
]);
const requestor: FDv2Requestor = {
Expand Down
4 changes: 0 additions & 4 deletions packages/shared/sdk-client/__tests__/datasource/fdv2/StreamingFDv2Base.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,6 @@ it('produces a goodbye status result', async () => {

simulateEvent(mockEventSource, 'goodbye', {
reason: 'server restarting',
silent: false,
catastrophe: false,
});

const result = await base.takeResult();
Expand Down Expand Up @@ -416,8 +414,6 @@ it('produces results in order', async () => {

simulateEvent(mockEventSource, 'goodbye', {
reason: 'bye',
silent: false,
catastrophe: false,
});

const r1 = await base.takeResult();
Expand Down
Loading