ci: Run v3 (FDv2) contract tests for server-node via gh-actions#1359
Merged
ci: Run v3 (FDv2) contract tests for server-node via gh-actions#1359
Conversation
Replace the manual feat/fdv2 branch clone with a second invocation of launchdarkly/gh-actions/actions/contract-tests pinned to v3.0.0-alpha.6, mirroring the python-server-sdk pattern. The v2 run now sets stop_service: 'false' so the test service stays alive for the v3 run.
Contributor
|
@launchdarkly/js-sdk-common size report |
Contributor
|
@launchdarkly/browser size report |
Contributor
|
@launchdarkly/js-client-sdk size report |
Contributor
|
@launchdarkly/js-client-sdk-common size report |
joker23
approved these changes
May 6, 2026
The previous pin (v1.0.2) did not recognize the stop_service input and unconditionally appended -stop-service-at-end, killing the test service between the v2 and v3 runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
feat/fdv2branch clone in.github/workflows/server-node.ymlwith a second invocation oflaunchdarkly/gh-actions/actions/contract-testspinned toversion: v3.0.0-alpha.6, mirroring the python-server-sdk pattern.stop_service: 'false'on the v2 run so the test service stays alive for the v3 run.-stop-service-at-endfromextra_params-- the action injects it viastop_service.packages/sdk/server-node/contract-tests/README.mdto describe the suppression files in terms of v2/v3 instead of the now-removedfeat/fdv2branch.Note
Medium Risk
CI behavior changes by switching from a manual harness checkout/build to the
contract-testsGitHub Action and adding a second (v3) run; failures or action/version mismatches could break the server-node pipeline.Overview
Updates the server-node CI contract test workflow to run both v2 and v3 (FDv2) harness suites using the
launchdarkly/gh-actions/actions/contract-testsaction, removing the previous manual clone/build of thesdk-test-harnessfeat/fdv2branch.The v2 run is configured to keep the test service alive (
stop_service: 'false') so a second invocation can execute the v3 alpha harness (version: v3.0.0-alpha.6) with its own suppression list. Documentation incontract-tests/README.mdis updated to describe suppression files in terms of v2 vs v3 rather than the removed branch-based flow.Reviewed by Cursor Bugbot for commit f2d2a6c. Bugbot is set up for automated code reviews on this repo. Configure here.