Skip to content

chore: Suppress failing hook test#1386

Merged
jsonbailey merged 4 commits into
mainfrom
suppress-hooks-test
May 19, 2026
Merged

chore: Suppress failing hook test#1386
jsonbailey merged 4 commits into
mainfrom
suppress-hooks-test

Conversation

@jsonbailey

@jsonbailey jsonbailey commented May 18, 2026

Copy link
Copy Markdown
Contributor

Note

Low Risk
Low runtime risk since changes only adjust contract-test suppression lists, but it reduces coverage by masking failures in hook ordering behavior across multiple SDKs.

Overview
Adds new entries to multiple contract-test suppression lists to ignore the failing hook ordering cases: hooks/evaluation/executes beforeEvaluation hooks in registration order and hooks/track/executes afterTrack hooks in registration order (browser, react, electron, and server-node test harness including FDv2).

Reviewed by Cursor Bugbot for commit 5262653. Bugbot is set up for automated code reviews on this repo. Configure here.

@jsonbailey jsonbailey requested a review from a team as a code owner May 18, 2026 23:50
@github-actions

Copy link
Copy Markdown
Contributor

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 26208 bytes
Compressed size limit: 29000
Uncompressed size: 128789 bytes

@github-actions

Copy link
Copy Markdown
Contributor

@launchdarkly/browser size report
This is the brotli compressed size of the ESM build.
Compressed size: 179498 bytes
Compressed size limit: 200000
Uncompressed size: 830837 bytes

@github-actions

Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Compressed size: 31906 bytes
Compressed size limit: 34000
Uncompressed size: 113658 bytes

@github-actions

Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 38487 bytes
Compressed size limit: 39000
Uncompressed size: 211236 bytes

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default mode and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit e1292fa. Configure here.

Comment thread packages/sdk/browser/contract-tests/suppressions_datamode_changes.txt Outdated
@jsonbailey jsonbailey merged commit 44350e8 into main May 19, 2026
42 checks passed
@jsonbailey jsonbailey deleted the suppress-hooks-test branch May 19, 2026 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants