Skip to content

ci: fixing electron ci breaking #1395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joker23 merged 1 commit into from
May 28, 2026
+6 −3
Merged

ci: fixing electron ci breaking #1395

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .github/workflows/electron.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,11 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
# Node versions to run on.
version: [24]
# NOTE: we need to pin this particular version for electron because
# 24.16 introduce some breaking changes affecting electron installation.
# We should monitor if NodeJS patches anything on that minor version before
# putting this back to latest LTS.
version: [24.15]
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
- uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
Expand Down Expand Up @@ -80,7 +83,7 @@ jobs:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
- uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 24
node-version: 24.15
- uses: ./actions/run-example
with:
workspace_name: '@launchdarkly/electron-example'
Expand Down
Loading