Skip to content

fix: Ensure FDv2 waits for network results instead of cached results.#1397

Merged
kinyoklion merged 2 commits into
mainfrom
rlamb/fdv2-wait-network
May 28, 2026
Merged

fix: Ensure FDv2 waits for network results instead of cached results.#1397
kinyoklion merged 2 commits into
mainfrom
rlamb/fdv2-wait-network

Conversation

@kinyoklion
Copy link
Copy Markdown
Member

@kinyoklion kinyoklion commented May 28, 2026

Note

Low Risk
Single-path behavior change in browser identify options; aligns with documented browser-only network semantics and does not touch auth or persistence.

Overview
The browser client’s identifyResult path now always passes waitForNetworkResults: true into the shared identify flow so FDv2 identify completes on fresh network flag data instead of settling on cached results.

The identify options object is typed as LDBaseIdentifyOptions, and when sheddable is already provided the code copies options with a spread (same as the default branch) before setting waitForNetworkResults.

Reviewed by Cursor Bugbot for commit 4f086c7. Bugbot is set up for automated code reviews on this repo. Configure here.

@kinyoklion kinyoklion requested a review from a team as a code owner May 28, 2026 22:35
@github-actions
Copy link
Copy Markdown
Contributor

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 26389 bytes
Compressed size limit: 29000
Uncompressed size: 129320 bytes

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 28, 2026

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Compressed size: 31882 bytes
Compressed size limit: 34000
Uncompressed size: 113733 bytes

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 28, 2026

@launchdarkly/browser size report
This is the brotli compressed size of the ESM build.
Compressed size: 179485 bytes
Compressed size limit: 200000
Uncompressed size: 830912 bytes

@github-actions
Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 38516 bytes
Compressed size limit: 39000
Uncompressed size: 211129 bytes

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit fa52d3a. Configure here.

Comment thread packages/sdk/browser/src/BrowserClient.ts
@kinyoklion kinyoklion merged commit 142da36 into main May 28, 2026
42 checks passed
@kinyoklion kinyoklion deleted the rlamb/fdv2-wait-network branch May 28, 2026 23:32
@github-actions github-actions Bot mentioned this pull request May 28, 2026
kinyoklion pushed a commit that referenced this pull request May 28, 2026
🤖 I have created a release *beep* *boop*
---


<details><summary>browser: 0.1.24</summary>

##
[0.1.24](browser-v0.1.23...browser-v0.1.24)
(2026-05-28)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @launchdarkly/js-client-sdk bumped from 4.7.2 to 4.7.3
</details>

<details><summary>js-client-sdk: 4.7.3</summary>

##
[4.7.3](js-client-sdk-v4.7.2...js-client-sdk-v4.7.3)
(2026-05-28)


### Bug Fixes

* Ensure FDv2 waits for network results instead of cached results.
([#1397](#1397))
([142da36](142da36))
</details>

<details><summary>react-sdk: 4.0.5</summary>

##
[4.0.5](react-sdk-v4.0.4...react-sdk-v4.0.5)
(2026-05-28)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @launchdarkly/js-client-sdk bumped from ^4.7.2 to ^4.7.3
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> No application logic in the diff—only version numbers, changelogs, and
dependency pins from automated release tooling.
> 
> **Overview**
> Release Please version bump for **@launchdarkly/js-client-sdk**
**4.7.3**, with changelog noting the shipped fix that **FDv2 waits for
network results instead of cached results**
([#1397](#1397)). The diff
itself is release metadata: `.release-please-manifest.json`, package
versions, changelogs, example app dependency pins, and embedded SDK
version strings in `BrowserInfo` and the React client default
`wrapperVersion`.
> 
> **@launchdarkly/browser** **0.1.24** and **@launchdarkly/react-sdk**
**4.0.5** are dependency-only releases that pick up **js-client-sdk**
**4.7.3**; React examples and combined-browser likewise update their
pinned versions.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
9282971. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants