chore: node-client-sdk implement sdk client#1400
Conversation
|
@cursor review |
|
@launchdarkly/js-sdk-common size report |
|
@launchdarkly/js-client-sdk-common size report |
|
@launchdarkly/js-client-sdk size report |
|
@launchdarkly/browser size report |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| highTimeoutThreshold: 15, | ||
| getImplementationHooks: (_environmentMetadata: LDPluginEnvironmentMetadata) => | ||
| internal.safeGetHooks(logger, _environmentMetadata, validatedNodeOptions.plugins), | ||
| credentialType: 'clientSideId', |
There was a problem hiding this comment.
Maybe also support taking in mobile key?
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 2767d76. Configure here.
joker23
force-pushed
the
skz/sdk-2195/node-client-sdk-next-port-client
branch
from
2767d76 to
06524cd
Compare
joker23
force-pushed
the
skz/sdk-2195/node-client-sdk-next-port-client
branch
from
06524cd to
a445510
Compare
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
going to try to break this PR up a bit more |
1 participant
Note
Medium Risk
Large new SDK surface touching identify/streaming, TLS, and persistent flag cache; behavior is heavily tested but mistakes could affect flag correctness or network/security defaults in production adopters.
Overview
Replaces the @launchdarkly/node-client-sdk placeholder with a full client-side SDK for Node:
createClient,client.start(), typedLDClient, and re-exports fromjs-client-sdk-common.NodeClient/NodeDataManagerwire streaming, polling, and offline modes, bootstrap vs cache (bootstrap skips cache), serializedsetConnectionModewith flush-before-offline and analytics toggling, and identify edge cases (post-close, offline mid-identify).NodeOptionsnow extends common LD options withinitialConnectionMode, plugins, secure-modehash, and existing TLS/cache settings;options.tsvalidates Node-specific fields.Platform hardening: default HTTP timeout, response body cap, safer flag-cache read/write and singleton path warnings. Broad Jest coverage (bootstrap, data source, events, mocks).
release-pleaseno longer bumps version inindex.ts.Reviewed by Cursor Bugbot for commit 027ee32. Bugbot is set up for automated code reviews on this repo. Configure here.