From 1a0d9dc9c8c473064e80b91c8a5aa6f598cf90a2 Mon Sep 17 00:00:00 2001
From: Steven Zhang <szhang@launchdarkly.com>
Date: Thu, 4 Jun 2026 18:07:55 -0400
Subject: [PATCH] fix: explicit return types and TS6 source compatibility fixes

---
 packages/sdk/fastly/src/api/createOptions.ts                    | 2 +-
 packages/sdk/shopify-oxygen/src/utils/createOptions.ts          | 2 +-
 .../shared/akamai-edgeworker-sdk/src/utils/createOptions.ts     | 2 +-
 .../common/__tests__/internal/events/EventProcessor.test.ts     | 1 +
 packages/shared/sdk-server-edge/src/api/createOptions.ts        | 2 +-
 packages/shared/sdk-server/src/store/sortDataSet.ts             | 2 +-
 6 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/packages/sdk/fastly/src/api/createOptions.ts b/packages/sdk/fastly/src/api/createOptions.ts
index 4ee08d6dd1..a5b2319f6f 100644
--- a/packages/sdk/fastly/src/api/createOptions.ts
+++ b/packages/sdk/fastly/src/api/createOptions.ts
@@ -8,7 +8,7 @@ export const defaultOptions: LDOptions = {
   logger: BasicLogger.get(),
 };
 
-const createOptions = (options: LDOptions) => {
+const createOptions = (options: LDOptions): LDOptions => {
   const finalOptions = { ...defaultOptions, ...options };
 
   // The Fastly SDK does not poll LaunchDarkly for updates, so a custom baseUri does not make sense. However, we need
diff --git a/packages/sdk/shopify-oxygen/src/utils/createOptions.ts b/packages/sdk/shopify-oxygen/src/utils/createOptions.ts
index 62ed23dbf2..f41f45a9e1 100644
--- a/packages/sdk/shopify-oxygen/src/utils/createOptions.ts
+++ b/packages/sdk/shopify-oxygen/src/utils/createOptions.ts
@@ -26,7 +26,7 @@ export const defaultOptions: LDOptions & OxygenLDOptions = {
   },
 };
 
-export const createOptions = (options: LDOptions & OxygenLDOptions = {}) => {
+export const createOptions = (options: LDOptions & OxygenLDOptions = {}): LDOptions & OxygenLDOptions => {
   const finalOptions = {
     ...defaultOptions,
     ...options,
diff --git a/packages/shared/akamai-edgeworker-sdk/src/utils/createOptions.ts b/packages/shared/akamai-edgeworker-sdk/src/utils/createOptions.ts
index 01ca5894d7..a59d657021 100644
--- a/packages/shared/akamai-edgeworker-sdk/src/utils/createOptions.ts
+++ b/packages/shared/akamai-edgeworker-sdk/src/utils/createOptions.ts
@@ -8,7 +8,7 @@ export const defaultOptions: LDOptions = {
   logger: BasicLogger.get(),
 };
 
-export const createOptions = (options: LDOptions) => {
+export const createOptions = (options: LDOptions): LDOptions => {
   const finalOptions = { ...defaultOptions, ...options };
   finalOptions.logger?.debug(`Using LD options: ${JSON.stringify(finalOptions)}`);
   return finalOptions;
diff --git a/packages/shared/common/__tests__/internal/events/EventProcessor.test.ts b/packages/shared/common/__tests__/internal/events/EventProcessor.test.ts
index 49456024b7..aaf33ae0ee 100644
--- a/packages/shared/common/__tests__/internal/events/EventProcessor.test.ts
+++ b/packages/shared/common/__tests__/internal/events/EventProcessor.test.ts
@@ -50,6 +50,7 @@ const mockSendEventData = jest.fn();
 jest.useFakeTimers();
 
 jest.mock('../../../src/internal/events/EventSender', () => ({
+  __esModule: true,
   default: jest.fn(() => ({
     sendEventData: mockSendEventData,
   })),
diff --git a/packages/shared/sdk-server-edge/src/api/createOptions.ts b/packages/shared/sdk-server-edge/src/api/createOptions.ts
index 3d5fb2d403..a5b524c5b1 100644
--- a/packages/shared/sdk-server-edge/src/api/createOptions.ts
+++ b/packages/shared/sdk-server-edge/src/api/createOptions.ts
@@ -8,6 +8,6 @@ export const defaultOptions: LDOptions = {
   logger: BasicLogger.get(),
 };
 
-const createOptions = (options: LDOptions) => ({ ...defaultOptions, ...options });
+const createOptions = (options: LDOptions): LDOptions => ({ ...defaultOptions, ...options });
 
 export default createOptions;
diff --git a/packages/shared/sdk-server/src/store/sortDataSet.ts b/packages/shared/sdk-server/src/store/sortDataSet.ts
index 3812faa2d6..4f35819d97 100644
--- a/packages/shared/sdk-server/src/store/sortDataSet.ts
+++ b/packages/shared/sdk-server/src/store/sortDataSet.ts
@@ -51,7 +51,7 @@ function topologicalSort(
 
   while (unvisitedItems.size > 0) {
     // Visit the next item, the order we visit doesn't matter.
-    const key = unvisitedItems.values().next().value;
+    const key = unvisitedItems.values().next().value!;
     visit(key);
   }
   return sortedItems;