Skip to content

docs(openfeature-node-server): adding jsdocs to public interfaces#1433

Open
joker23 wants to merge 1 commit into
mainfrom
skz/sdk-2213/openfeature-migration-jsdocs
Open

docs(openfeature-node-server): adding jsdocs to public interfaces#1433
joker23 wants to merge 1 commit into
mainfrom
skz/sdk-2213/openfeature-migration-jsdocs

Conversation

@joker23

@joker23 joker23 commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Note

Low Risk
Comment-only changes with no runtime or API behavior modifications.

Overview
Adds JSDoc to public surfaces in openfeature-server-common so generated API docs and IDE hints better describe the LaunchDarkly OpenFeature server provider.

BaseOpenFeatureProvider gains comments on metadata, lifecycle (initialize, onClose), typed resolve*Evaluation methods, hooks, getClient, and track. OpenFeatureLDClientContract documents each method on the minimal LD client interface. translateContext documents its logger parameter.

Reviewed by Cursor Bugbot for commit a539b07. Bugbot is set up for automated code reviews on this repo. Configure here.

@joker23 joker23 requested a review from a team as a code owner June 8, 2026 19:56
@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 26365 bytes
Compressed size limit: 29000
Uncompressed size: 129044 bytes

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 38739 bytes
Compressed size limit: 39000
Uncompressed size: 212244 bytes

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

@launchdarkly/browser size report
This is the brotli compressed size of the ESM build.
Compressed size: 179579 bytes
Compressed size limit: 200000
Uncompressed size: 831422 bytes

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Compressed size: 31978 bytes
Compressed size limit: 34000
Uncompressed size: 114243 bytes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant