Skip to content

chore: adding vue client sdk wrapper#1435

Open
joker23 wants to merge 1 commit into
mainfrom
skz/sdk-2194/migrate-vue-sdk-client-wrapper
Open

chore: adding vue client sdk wrapper#1435
joker23 wants to merge 1 commit into
mainfrom
skz/sdk-2194/migrate-vue-sdk-client-wrapper

Conversation

@joker23

@joker23 joker23 commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Additional changes:

  • modified tsconfig.json to match the rest of the monorepo

Note

Low Risk
New package scaffolding and client wrapper with no changes to existing SDKs; behavior is covered by unit tests and mirrors the established React wrapper pattern.

Overview
Introduces the first real Vue client SDK surface by replacing the empty package export with a createClient wrapper around @launchdarkly/js-client-sdk, following the same pattern as the React wrapper.

The wrapper injects vue-client-sdk wrapper metadata, tracks initialization state (initializing / complete / failed), exposes isReady, getInitializationError, and subscription APIs for init status (with replay for late subscribers) and context changes after successful start() / identify(). Types for LDVueClient, LDVueInstance, and LDVueProviderOptions are added ahead of provider/composables in a follow-up PR.

Package/tooling: adds a workspace dependency on the JS client SDK, enables Jest without passWithNoTests, and adds jsdom / Vue test utils. tsconfig.json is updated to ES2020 and moduleResolution: bundler to match other SDK packages. Unit tests cover wrapper metadata, init lifecycle, subscriber behavior, and identify error paths.

Reviewed by Cursor Bugbot for commit bc71f02. Bugbot is set up for automated code reviews on this repo. Configure here.

Additional changes:
- modified tsconfig.json to match the rest of the monorepo
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 26365 bytes
Compressed size limit: 29000
Uncompressed size: 129044 bytes

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Compressed size: 31978 bytes
Compressed size limit: 34000
Uncompressed size: 114243 bytes

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 38739 bytes
Compressed size limit: 39000
Uncompressed size: 212244 bytes

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

@launchdarkly/browser size report
This is the brotli compressed size of the ESM build.
Compressed size: 179579 bytes
Compressed size limit: 200000
Uncompressed size: 831422 bytes

@joker23

joker23 commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

@cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit bc71f02. Configure here.

@joker23 joker23 marked this pull request as ready for review June 9, 2026 15:59
@joker23 joker23 requested a review from a team as a code owner June 9, 2026 15:59

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 4 additional findings.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant