test: update test implementation to work well with typescript 6#1436
test: update test implementation to work well with typescript 6#1436joker23 wants to merge 1 commit into
Conversation
|
@launchdarkly/js-sdk-common size report |
|
@launchdarkly/js-client-sdk size report |
|
@launchdarkly/browser size report |
joker23
force-pushed
the
skz/sdk-2193/typescript-6-esModuleInterop-changes
branch
from
0f187c2 to
73ce3d2
Compare
|
@launchdarkly/js-client-sdk-common size report |
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 73ce3d2. Configure here.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
joker23
force-pushed
the
skz/sdk-2193/typescript-6-esModuleInterop-changes
branch
from
73ce3d2 to
d2160b2
Compare
1 participant
This PR will update the way that tests import modules. This is to make the syntax of this module compatible with typescript 6.
Specifically the issue that the current syntax runs into is detailed in https://devblogs.microsoft.com/typescript/announcing-typescript-6-0/#deprecated:---esmoduleinterop-false-and---allowsyntheticdefaultimports-false
Note
Low Risk
Changes are limited to TypeScript compiler options and test/fixture import style; no production SDK runtime logic is modified.
Overview
Prepares the monorepo for TypeScript 6 by turning on
esModuleInterop: trueintsconfig.jsonfor edge SDK packages (akamai-*,cloudflare,fastly,shopify-oxygen,vercel) and shared libs (sdk-client,akamai-edgeworker-sdk,sdk-server-edge).Test and setup code now default-imports JSON fixtures (e.g.
import testData from './testData.json') instead of namespace imports (import * as testData), matching the interop model TS 6 expects when the oldesModuleInterop: falsestyle is deprecated.packages/sdk/fastly/jest.config.jsonis reformatted only; behavior is unchanged.Reviewed by Cursor Bugbot for commit d2160b2. Bugbot is set up for automated code reviews on this repo. Configure here.