fix: add SOCKS proxy example and fixes warning logging and proxyAuth reporting#1786
Conversation
The SDK cannot inspect a caller-supplied proxyAgent to know whether it carries its own credentials (for example a SOCKS URL's embedded username/password), so usingProxyAuth() now reports true for any supplied proxyAgent rather than only when proxyOptions.auth is set, matching the existing best-effort reasoning for usingProxy().
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
@launchdarkly/js-sdk-common size report |
|
@launchdarkly/browser size report |
|
@launchdarkly/js-client-sdk-common size report |
|
@launchdarkly/js-client-sdk size report |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
1933703 to
30421d6
Compare
2 participants
This PR mainly adds an example for how to use SOCKS proxy agent in node server sdk
Additionally this PR will pull in fixes that were not included in the previous PR
proxyAgentoption will no longer log a "unknown property" warningproxyAgentwill also reportproxyAuthusage to diagnostic eventNote
Low Risk
Changes are limited to Node-specific networking/diagnostics behavior, documentation, and CI; no auth or data-path redesign beyond more accurate diagnostic flags when using custom agents.
Overview
Adds a custom SOCKS proxy example for the Node server SDK that wires
SocksProxyAgentintoproxyAgent, plus Dante-based proxy assets and a CI job that runs the example and checks proxy logs for real traffic.Fixes
proxyAgenthandling: strip it from options passed into sharedLDClientImplso it is not logged as an unknown config option, and treat a suppliedproxyAgentas a best-effort signal for proxy auth in diagnostics (usingProxyAuth()/_hasProxyAuth), matching SOCKS URLs with embedded credentials. Tests andLDOptionsdocs are updated accordingly; the example is registered in workspaces, release-please, and excluded from the main SDKtsconfigbuild.Reviewed by Cursor Bugbot for commit 55e41b9. Bugbot is set up for automated code reviews on this repo. Configure here.