Skip to content

Commit 00a77b6

Browse files
devin-ai-integration[bot]rapha-ldnhironaka
authored
style(components): improve dark-mode Modal and Popover differentiation (#1943)
* style(components): improve dark-mode Modal and Popover differentiation Co-Authored-By: rhalloran@launchdarkly.com <rhalloran@launchdarkly.com> * rebuild --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: rhalloran@launchdarkly.com <rhalloran@launchdarkly.com> Co-authored-by: Naomi Hironaka <nhironaka@launchdarkly.com>
1 parent cb9e26b commit 00a77b6

3 files changed

Lines changed: 13 additions & 2 deletions

File tree

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@launchpad-ui/components': patch
3+
---
4+
5+
Improve dark-mode differentiation for `Modal` and `Popover` surfaces by adding a subtle border and a deeper drop shadow with a hairline ring. The additions are scoped to dark themes via `light-dark()`, so light themes are unchanged.

packages/components/src/styles/Modal.module.css

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,11 +43,14 @@
4343
.base {
4444
border-radius: var(--lp-border-radius-medium);
4545
background-color: var(--lp-color-bg-overlay-primary);
46+
border: 1px solid light-dark(transparent, var(--lp-color-border-ui-primary));
4647
outline: none;
4748
padding: var(--lp-spacing-700);
4849
box-shadow:
4950
0px 0px 16px 0px var(--lp-color-shadow-ui-secondary),
50-
0px 8px 36px 0px var(--lp-color-shadow-ui-primary);
51+
0px 8px 36px 0px var(--lp-color-shadow-ui-primary),
52+
0px 20px 60px 0px light-dark(transparent, var(--lp-color-black-500)),
53+
0px 0px 0px 1px light-dark(transparent, var(--lp-color-white-0));
5154

5255
& [slot='title'] {
5356
font: var(--lp-text-heading-1-semibold);

packages/components/src/styles/Popover.module.css

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,14 @@
1717
border-radius: var(--lp-border-radius-medium);
1818
color: var(--lp-color-text-ui-primary-base);
1919
background-color: var(--lp-color-bg-overlay-secondary);
20+
border: 1px solid light-dark(transparent, var(--lp-color-border-ui-primary));
2021
box-shadow:
2122
0px 0px 1px 0px var(--lp-color-shadow-ui-secondary),
2223
0px 0px 4px 0px var(--lp-color-shadow-ui-secondary),
2324
0px 4px 8px 0px var(--lp-color-shadow-ui-secondary),
24-
0px 2px 12px 0px var(--lp-color-shadow-ui-secondary);
25+
0px 2px 12px 0px var(--lp-color-shadow-ui-secondary),
26+
0px 20px 60px 0px light-dark(transparent, var(--lp-color-black-500)),
27+
0px 0px 0px 1px light-dark(transparent, var(--lp-color-white-0));
2528
transform: translate3d(0, 0, 0);
2629
will-change: transform, opacity;
2730

0 commit comments

Comments
 (0)