feat: revert Alert styles#1889
Conversation
|
nhironaka
added
the
skip changeset
commit: |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 958a3b6. Configure here.
| &:has(.heading) { | ||
| /* biome-ignore lint/style/noDescendingSpecificity: ignore */ | ||
| & .icon { | ||
| transform: translateY(2px); |
There was a problem hiding this comment.
Hardcoded pixel value in transform instead of design token
Low Severity
The transform: translateY(2px) uses a hardcoded pixel value instead of the --lp-size-2 design token. Other files in this codebase (e.g., Calendar.module.css, Popover.module.css) already use var(--lp-size-2) for the equivalent value. This is not inside a calc() expression alongside a design token, so the exception for fine alignment adjustments does not apply.
Triggered by learned rule: Prefer --lp-size-* design tokens over hardcoded pixel values in component styles
Reviewed by Cursor Bugbot for commit 958a3b6. Configure here.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
2 participants
Summary
Reverting to unblock releases
Screenshots (if appropriate):
Testing approaches
Note
Medium Risk
This reverts previously introduced
AlertAPI surface (AlertText,actionsLayout,hideIcon) and significantly changesAlertstyling/markup, which can break consumers and visual layouts but does not touch security- or data-critical logic.Overview
Reverts the recent
Alertexpansion by removingAlertTextand dropping theactionsLayout/hideIconprops fromAlert(and from the package exports), simplifying the component API.Updates
Alertrendering and CSS to a new banner-like presentation (adds a top gradient bar for default variant, tweaks icon/close button sizing and positioning, and adjusts spacing/heading/button-group styles), and simplifies Storybook stories/controls accordingly. Also removes the related changeset entries.Reviewed by Cursor Bugbot for commit 958a3b6. Bugbot is set up for automated code reviews on this repo. Configure here.