Skip to content

Commit 62e99ed

Browse files
authored
chore: [REL-4161] Finalize Release GHA (#529)
This should be ready to go now <!-- ld-jira-link --> --- Related Jira issue: [REL-4161: Migrate ld-find-code-refs from Releaser to GHA](https://launchdarkly.atlassian.net/browse/REL-4161) <!-- end-ld-jira-link -->
1 parent 01f08cc commit 62e99ed

2 files changed

Lines changed: 2 additions & 19 deletions

File tree

.github/workflows/release.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ jobs:
2626
LD_RELEASE_VERSION: ${{ inputs.releaseVersion }}
2727
DRY_RUN: ${{ inputs.dryRun || 'false' }}
2828
CHANGELOG_ENTRY: ${{ inputs.changeLog }}
29-
CHANGELOG_JSON: ${{ toJSON(inputs.changeLog) }}
3029
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
3130
ARTIFACT_DIRECTORY: "/tmp/release-artifacts"
3231
steps:
@@ -77,5 +76,5 @@ jobs:
7776
with:
7877
token: ${{ secrets.GITHUB_TOKEN }}
7978
tag: v${{ inputs.releaseVersion }}
80-
body: ${{ fromJSON(toJSON(inputs.changeLog)) }}
79+
body: ${{ inputs.changeLog }}
8180
artifacts: ${{ env.ARTIFACT_DIRECTORY }}/*

scripts/release/commit-and-tag.sh

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -11,23 +11,7 @@ tag_exists() (
1111

1212
update_changelog() (
1313
local ts=$(date +"%Y-%m-%d")
14-
15-
echo "raw changelog"
16-
echo "$CHANGELOG_ENTRY"
17-
18-
echo "json changelog"
19-
echo "$CHANGELOG_JSON"
20-
21-
local changelog_body=$(echo "$CHANGELOG_ENTRY" | sed "s/\\n/\n/g")
22-
local changelog_json=$(echo "$CHANGELOG_ENTRY" | jq -r .)
23-
24-
echo "parsed with sed"
25-
echo "$changelog_body"
26-
27-
echo "parsed with jq"
28-
echo "$changelog_json"
29-
30-
local changelog_entry=$(printf "## [%s] - %s\n%s\n" "$LD_RELEASE_VERSION" "$ts" "$changelog_body")
14+
local changelog_entry=$(printf "## [%s] - %s\n%s\n" "$LD_RELEASE_VERSION" "$ts" "$CHANGELOG_ENTRY")
3115

3216
# insert the new changelog entry (followed by empty line) after line 4
3317
# of CHANGELOG.md

0 commit comments

Comments
 (0)