Skip to content

Commit 8e56bb1

Browse files
chore(deps): bump golang.org/x/crypto to v0.52.0 (#605)
## Summary Remediates the open CRITICAL Dependabot alert for `golang.org/x/crypto` by bumping it from `v0.45.0` to `v0.52.0` (patched version). `golang.org/x/crypto v0.52.0` requires Go >= 1.25, so this also bumps the module `go` directive `1.24.0 → 1.25.0` (and drops the now-redundant `toolchain go1.24.1` line). CI resolves its Go version from `go.mod` (`go-version-file: go.mod`); there are no Dockerfile pinned Go versions to update. ``` golang.org/x/crypto v0.45.0 -> v0.52.0 (fixes CRITICAL alert) go 1.24.0 -> 1.25.0 (required by x/crypto v0.52.0) ``` Transitive `golang.org/x/{net,sys,text,term}` were pulled forward by `go mod tidy` as a consequence. The `vendor/` tree was regenerated via `go mod vendor` — hence the large (mechanical) vendored diff. ### CI lint compatibility (`ci:` commit) The Go 1.25 bump broke the CI `go-tests` job: the pinned `golangci-lint v1.64.4` (built with Go 1.24) refuses to target a `go 1.25.0` module. Upgraded the lint step to `golangci-lint-action@v8.0.0` + `golangci-lint v2.5.0` (built with Go 1.25) and migrated `.golangci.yml` to the v2 schema (via `golangci-lint migrate`). To preserve the *prior effective* linter behavior (and avoid reformatting unrelated source), the v2-only linters that would otherwise fire on existing code are disabled (`funcorder`, `godoclint`, `noinlineerr`, `wsl_v5`), and staticcheck is configured to exclude the `ST1*`/`QF1*` check groups (v1 had `stylecheck` disabled). The old `goimports` `local-prefixes` setting was dropped because the v1 config used the misspelled key `linter-settings`, so it was silently ignored and never enforced. Verified locally: `go build ./...`, `go vet ./...`, `go test ./...`, and `golangci-lint run ./...` (v2.5.0) all pass. CI green. Link to Devin session: https://app.devin.ai/sessions/77c5bbaf5b114aac80ad2c021c2b14f4 Requested by: @kparkinson-ld --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
1 parent fbd693c commit 8e56bb1

129 files changed

Lines changed: 8146 additions & 36509 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.github/workflows/main.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,9 @@ jobs:
2525
go install gotest.tools/gotestsum@latest
2626
2727
- name: Install golangci-lint
28-
uses: golangci/golangci-lint-action@971e284b6050e8a5849b72094c50ab08da042db8 # v6.1.1
28+
uses: golangci/golangci-lint-action@25e2cdc5eb1d7a04fdc45ff538f1a00e960ae128 # v8.0.0
2929
with:
30-
version: v1.64.4
30+
version: v2.5.0
3131

3232
- name: Run tests with gotestsum
3333
run: |

.golangci.yml

Lines changed: 68 additions & 58 deletions
Original file line numberDiff line numberDiff line change
@@ -1,64 +1,74 @@
1-
project_name: ld-find-code-refs
2-
1+
version: "2"
32
run:
4-
deadline: 120s
53
tests: false
6-
74
linters:
8-
enable-all: true
5+
default: all
96
disable:
10-
- golint
11-
- stylecheck
12-
- gochecknoglobals
13-
- lll
14-
- errcheck
15-
- interfacer
16-
- tagliatelle
17-
- varnamelen
18-
- nonamedreturns
19-
- nlreturn # re-enable this after fixing all cases
20-
- gomnd # re-enable this after fixing all cases
21-
- nosnakecase
22-
- ifshort # re-enable
23-
- nilerr #re-enable
24-
- goerr113
25-
- exhaustivestruct
26-
- exhaustruct
27-
- exhaustive
28-
- godot
29-
- wsl #fix
30-
- gocognit
31-
- revive
32-
- errname
33-
- cyclop
34-
- gofumpt # fix
35-
- gci
36-
- nestif # fix
37-
- gosec
38-
- gocritic
39-
- depguard
40-
- tagalign
41-
- nilnil
42-
fast: false
43-
44-
linter-settings:
45-
goimports:
46-
local-prefixes: github.com/launchdarkly,gopkg.in/launchdarkly
47-
7+
- cyclop
8+
- depguard
9+
- err113
10+
- errcheck
11+
- errname
12+
- exhaustive
13+
- exhaustruct
14+
- funcorder
15+
- gochecknoglobals
16+
- gocognit
17+
- gocritic
18+
- godoclint
19+
- godot
20+
- gosec
21+
- lll
22+
- mnd
23+
- nestif
24+
- nilerr
25+
- nilnil
26+
- nlreturn
27+
- noinlineerr
28+
- nonamedreturns
29+
- revive
30+
- tagalign
31+
- tagliatelle
32+
- varnamelen
33+
- wsl
34+
- wsl_v5
35+
settings:
36+
staticcheck:
37+
checks:
38+
- all
39+
- -ST1*
40+
- -QF1*
41+
exclusions:
42+
generated: lax
43+
rules:
44+
- linters:
45+
- staticcheck
46+
text: SA5011
47+
- path: (.+)\.go$
48+
text: error returned from external package is unwrapped
49+
- path: (.+)\.go$
50+
text: error returned from interface method should be wrapped
51+
- path: (.+)\.go$
52+
text: comparing with == will fail on wrapped errors. Use errors.Is to check for a specific error
53+
- path: (.+)\.go$
54+
text: comparing with != will fail on wrapped errors. Use errors.Is to check for a specific error
55+
- path: (.+)\.go$
56+
text: non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
57+
- path: (.+)\.go$
58+
text: append to slice `projectKeys` with non-zero initialized length
59+
paths:
60+
- third_party$
61+
- builtin$
62+
- examples$
4863
issues:
49-
exclude:
50-
- "error returned from external package is unwrapped"
51-
- "error returned from interface method should be wrapped"
52-
- "comparing with == will fail on wrapped errors. Use errors.Is to check for a specific error" # should fix
53-
- "comparing with != will fail on wrapped errors. Use errors.Is to check for a specific error" # should fix
54-
- "non-wrapping format verb for fmt.Errorf. Use `%w` to format errors" # should fix
55-
- "append to slice `projectKeys` with non-zero initialized length"
56-
exclude-rules:
57-
# Exclude some `staticcheck` messages.
58-
- linters:
59-
- staticcheck
60-
text: "SA5011" # fix
61-
62-
exclude-use-default: false
6364
max-same-issues: 1000
64-
max-per-linter: 1000
65+
formatters:
66+
enable:
67+
- gofmt
68+
- goimports
69+
exclusions:
70+
generated: lax
71+
paths:
72+
- third_party$
73+
- builtin$
74+
- examples$

go.mod

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
module github.com/launchdarkly/ld-find-code-refs/v2
22

3-
go 1.24.0
4-
5-
toolchain go1.24.1
3+
go 1.25.0
64

75
require (
86
github.com/bmatcuk/doublestar/v4 v4.9.1
@@ -66,11 +64,11 @@ require (
6664
github.com/wasilibs/wazero-helpers v0.0.0-20240620070341-3dff1577cd52 // indirect
6765
github.com/xanzy/ssh-agent v0.3.3 // indirect
6866
go.yaml.in/yaml/v3 v3.0.4 // indirect
69-
golang.org/x/crypto v0.45.0 // indirect
70-
golang.org/x/net v0.47.0 // indirect
67+
golang.org/x/crypto v0.52.0 // indirect
68+
golang.org/x/net v0.54.0 // indirect
7169
golang.org/x/oauth2 v0.27.0 // indirect
72-
golang.org/x/sys v0.38.0 // indirect
73-
golang.org/x/text v0.31.0 // indirect
70+
golang.org/x/sys v0.45.0 // indirect
71+
golang.org/x/text v0.37.0 // indirect
7472
gopkg.in/warnings.v0 v0.1.2 // indirect
7573
gopkg.in/yaml.v3 v3.0.1 // indirect
7674
)

go.sum

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -262,8 +262,8 @@ golang.org/x/crypto v0.0.0-20190605123033-f99c8df09eb5/go.mod h1:yigFU9vqHzYiE8U
262262
golang.org/x/crypto v0.0.0-20191011191535-87dc89f01550/go.mod h1:yigFU9vqHzYiE8UmvKecakEJjdnWj3jj499lnFckfCI=
263263
golang.org/x/crypto v0.0.0-20200622213623-75b288015ac9/go.mod h1:LzIPMQfyMNhhGPhUkYOs5KpL4U8rLKemX1yGLhDgUto=
264264
golang.org/x/crypto v0.0.0-20220622213112-05595931fe9d/go.mod h1:IxCIyHEi3zRg3s0A5j5BB6A9Jmi73HwBIUl50j+osU4=
265-
golang.org/x/crypto v0.45.0 h1:jMBrvKuj23MTlT0bQEOBcAE0mjg8mK9RXFhRH6nyF3Q=
266-
golang.org/x/crypto v0.45.0/go.mod h1:XTGrrkGJve7CYK7J8PEww4aY7gM3qMCElcJQ8n8JdX4=
265+
golang.org/x/crypto v0.52.0 h1:RMs7fP2rXdep0CftQlK8Uf+kibLm7qkCcradZWYz988=
266+
golang.org/x/crypto v0.52.0/go.mod h1:1QgfPxDqh0T2M/elOJtp9RvuR95kVjir0e6/BvEmGbc=
267267
golang.org/x/exp v0.0.0-20190121172915-509febef88a4/go.mod h1:CJ0aWSM057203Lf6IL+f9T1iT9GByDxfZKAQTCR3kQA=
268268
golang.org/x/exp v0.0.0-20190306152737-a1d7652674e8/go.mod h1:CJ0aWSM057203Lf6IL+f9T1iT9GByDxfZKAQTCR3kQA=
269269
golang.org/x/exp v0.0.0-20190510132918-efd6b22b2522/go.mod h1:ZjyILWgesfNpC6sMxTJOJm9Kp84zZh5NQWvqDGG3Qr8=
@@ -323,8 +323,8 @@ golang.org/x/net v0.0.0-20200625001655-4c5254603344/go.mod h1:/O7V0waA8r7cgGh81R
323323
golang.org/x/net v0.0.0-20200707034311-ab3426394381/go.mod h1:/O7V0waA8r7cgGh81Ro3o1hOxt32SMVPicZroKQ2sZA=
324324
golang.org/x/net v0.0.0-20200822124328-c89045814202/go.mod h1:/O7V0waA8r7cgGh81Ro3o1hOxt32SMVPicZroKQ2sZA=
325325
golang.org/x/net v0.0.0-20211112202133-69e39bad7dc2/go.mod h1:9nx3DQGgdP8bBQD5qxJ1jj9UTztislL4KSBs9R2vV5Y=
326-
golang.org/x/net v0.47.0 h1:Mx+4dIFzqraBXUugkia1OOvlD6LemFo1ALMHjrXDOhY=
327-
golang.org/x/net v0.47.0/go.mod h1:/jNxtkgq5yWUGYkaZGqo27cfGZ1c5Nen03aYrrKpVRU=
326+
golang.org/x/net v0.54.0 h1:2zJIZAxAHV/OHCDTCOHAYehQzLfSXuf/5SoL/Dv6w/w=
327+
golang.org/x/net v0.54.0/go.mod h1:Sj4oj8jK6XmHpBZU/zWHw3BV3abl4Kvi+Ut7cQcY+cQ=
328328
golang.org/x/oauth2 v0.0.0-20180821212333-d2e6202438be/go.mod h1:N/0e6XlmueqKjAGxoOufVs8QHGRruUQn6yWY3a++T0U=
329329
golang.org/x/oauth2 v0.0.0-20190226205417-e64efc72b421/go.mod h1:gOpvHmFTYa4IltrdGE7lF6nIHvwfUNPOp7c8zoXwtLw=
330330
golang.org/x/oauth2 v0.0.0-20190604053449-0f29369cfe45/go.mod h1:gOpvHmFTYa4IltrdGE7lF6nIHvwfUNPOp7c8zoXwtLw=
@@ -374,19 +374,19 @@ golang.org/x/sys v0.0.0-20210615035016-665e8c7367d1/go.mod h1:oPkhp1MJrh7nUepCBc
374374
golang.org/x/sys v0.0.0-20220715151400-c0bba94af5f8/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
375375
golang.org/x/sys v0.0.0-20220811171246-fbc7d0a398ab/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
376376
golang.org/x/sys v0.6.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
377-
golang.org/x/sys v0.38.0 h1:3yZWxaJjBmCWXqhN1qh02AkOnCQ1poK6oF+a7xWL6Gc=
378-
golang.org/x/sys v0.38.0/go.mod h1:OgkHotnGiDImocRcuBABYBEXf8A9a87e/uXjp9XT3ks=
377+
golang.org/x/sys v0.45.0 h1:dO4czNzziLiiXplLQgBCEpCvXQ3dnkn0SdaZSYdQ+FY=
378+
golang.org/x/sys v0.45.0/go.mod h1:4GL1E5IUh+htKOUEOaiffhrAeqysfVGipDYzABqnCmw=
379379
golang.org/x/term v0.0.0-20201126162022-7de9c90e9dd1/go.mod h1:bj7SfCRtBDWHUb9snDiAeCFNEtKQo2Wmx5Cou7ajbmo=
380-
golang.org/x/term v0.37.0 h1:8EGAD0qCmHYZg6J17DvsMy9/wJ7/D/4pV/wfnld5lTU=
381-
golang.org/x/term v0.37.0/go.mod h1:5pB4lxRNYYVZuTLmy8oR2BH8dflOR+IbTYFD8fi3254=
380+
golang.org/x/term v0.43.0 h1:S4RLU2sB31O/NCl+zFN9Aru9A/Cq2aqKpTZJ6B+DwT4=
381+
golang.org/x/term v0.43.0/go.mod h1:lrhlHNdQJHO+1qVYiHfFKVuVioJIheAc3fBSMFYEIsk=
382382
golang.org/x/text v0.0.0-20170915032832-14c0d48ead0c/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=
383383
golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=
384384
golang.org/x/text v0.3.1-0.20180807135948-17ff2d5776d2/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=
385385
golang.org/x/text v0.3.2/go.mod h1:bEr9sfX3Q8Zfm5fL9x+3itogRgK3+ptLWKqgva+5dAk=
386386
golang.org/x/text v0.3.3/go.mod h1:5Zoc/QRtKVWzQhOtBMvqHzDpF6irO9z98xDceosuGiQ=
387387
golang.org/x/text v0.3.6/go.mod h1:5Zoc/QRtKVWzQhOtBMvqHzDpF6irO9z98xDceosuGiQ=
388-
golang.org/x/text v0.31.0 h1:aC8ghyu4JhP8VojJ2lEHBnochRno1sgL6nEi9WGFGMM=
389-
golang.org/x/text v0.31.0/go.mod h1:tKRAlv61yKIjGGHX/4tP1LTbc13YSec1pxVEWXzfoeM=
388+
golang.org/x/text v0.37.0 h1:Cqjiwd9eSg8e0QAkyCaQTNHFIIzWtidPahFWR83rTrc=
389+
golang.org/x/text v0.37.0/go.mod h1:a5sjxXGs9hsn/AJVwuElvCAo9v8QYLzvavO5z2PiM38=
390390
golang.org/x/time v0.0.0-20181108054448-85acf8d2951c/go.mod h1:tRJNPiyCQ0inRvYxbN9jk5I+vvW/OXSQhTDSoE431IQ=
391391
golang.org/x/time v0.0.0-20190308202827-9d24e82272b4/go.mod h1:tRJNPiyCQ0inRvYxbN9jk5I+vvW/OXSQhTDSoE431IQ=
392392
golang.org/x/time v0.0.0-20191024005414-555d28b269f0/go.mod h1:tRJNPiyCQ0inRvYxbN9jk5I+vvW/OXSQhTDSoE431IQ=

vendor/golang.org/x/crypto/blake2b/go125.go

Lines changed: 0 additions & 11 deletions
This file was deleted.

vendor/golang.org/x/crypto/hkdf/hkdf.go

Lines changed: 13 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/golang.org/x/crypto/ssh/agent/client.go

Lines changed: 7 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/golang.org/x/crypto/ssh/agent/keyring.go

Lines changed: 18 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/golang.org/x/crypto/ssh/agent/server.go

Lines changed: 7 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)