feat(credential): expose the full accepted key set via AcceptedKeys#730
Open
aaron-zeisler wants to merge 1 commit into
Open
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 06b94b2. Configure here.
Add AcceptedKey (type, value, optional identifier, optional expiry) and KeyType, plus Rotator.AcceptedKeys() to snapshot every accepted SDK and mobile key — anchor and primary mobile key included — and an EnvContext GetAcceptedKeys() accessor that delegates to it. The status endpoint will partition this set by type to build the sdkKeys[] / mobileKeys[] arrays.
aaron-zeisler
force-pushed
the
aaronz/SDK-2534/credential-key-identifiers
branch
from
072ed9f to
d3d3a0e
Compare
aaron-zeisler
force-pushed
the
aaronz/SDK-2534/rotator-accepted-keys
branch
from
06b94b2 to
f063227
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Stacked PR — splitting #724 (review/merge bottom-up):
mobileKeys[]AcceptedKeyssdkKeys[]/mobileKeys[]on/statusBase: #729.
Summary
Expose the full accepted credential set via
Rotator.AcceptedKeys()andEnvContext.GetAcceptedKeys()— every server-side SDK key and mobile key (anchor and primary mobile key included), each with its type, optional identifier, and optional expiry.Jira: SDK-2534
Background
Third in the stack splitting #724, based on #729; consumed next by #731, which partitions the returned set by type to build the
sdkKeys[]/mobileKeys[]response arrays.Changes
AcceptedKeyandKeyType, plusacceptedKeysOfandRotator.AcceptedKeys().EnvContext.GetAcceptedKeys()accessor, delegating to the rotator.DeprecatedCredentialsdoc reference to populatingexpiringSdkKey(that moves to the accepted-set path in feat(status): surface full sdkKeys[]/mobileKeys[] arrays on /status #731).