Merged
Conversation
added 4 commits
June 3, 2025 15:43
Apparently this skips the dependency checks, so we were creating broken npm publishes
This reverts commit 0573344.
launchdarkly-upra
Bot
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR removes unnecessary always() conditions to restore proper publish triggers and adds an in-container Docker login step to fix Docker Hub publish failures.
- Remove spurious
always()wrappers from release conditionals - Add
docker logininside the goreleaser container - Clean up unused Docker logout and env-pass steps
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/release-please.yml | Dropped always() from two if: expressions |
| .github/actions/publish/action.yml | Injected docker login into the running container; removed logout and direct env-pass flags |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix two things
always()conditions)Related Jira issue: FUN-804: Release new ldcli