Skip to content

Commit 73ce017

Browse files
committed
fix: Android span e2e tests (#397)
## Summary Fixes and removes ignore on span e2e tests. Flag Eval on the launch was intervening with tests <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk: changes are limited to the Android E2E test harness and test annotations, with no impact on production SDK logic beyond skipping a test-only span trigger during tests. > > **Overview** > Fixes flaky Android span E2E tests by preventing `BaseApplication` from running `flagEvaluation()` during test runs (gated on `testUrl == null`), avoiding extra spans that interfered with assertions. > > Re-enables previously ignored span-related E2E coverage by removing `@Ignore` from several trace/export and sampling tests in `DisablingConfigOptionsE2ETest` and `SamplingE2ETest`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 618e2b1. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent 17d6c5d commit 73ce017

1 file changed

Lines changed: 0 additions & 4 deletions

File tree

e2e/android/app/src/test/java/com/example/androidobservability/DisablingConfigOptionsE2ETest.kt

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,6 @@ class DisablingConfigOptionsE2ETest {
7373

7474

7575
@Test
76-
@Ignore
7776
fun `Spans should NOT be exported when TracesApi is disabled`() {
7877
application.observabilityOptions = getOptionsAllEnabled().copy(tracesApi = ObservabilityOptions.TracesApi.disabled())
7978
application.initForTest()
@@ -90,7 +89,6 @@ class DisablingConfigOptionsE2ETest {
9089
}
9190

9291
@Test
93-
@Ignore
9492
fun `Spans should NOT be exported when TracesApi does not include spans`() {
9593
application.observabilityOptions = getOptionsAllEnabled().copy(
9694
tracesApi = ObservabilityOptions.TracesApi(includeSpans = false)
@@ -152,7 +150,6 @@ class DisablingConfigOptionsE2ETest {
152150
}
153151

154152
@Test
155-
@Ignore
156153
fun `Errors should NOT be exported when TracesApi does not include errors`() {
157154
application.observabilityOptions = getOptionsAllEnabled().copy(
158155
tracesApi = ObservabilityOptions.TracesApi(includeErrors = false)
@@ -171,7 +168,6 @@ class DisablingConfigOptionsE2ETest {
171168
}
172169

173170
@Test
174-
@Ignore
175171
fun `Errors should be exported as spans when TracesApi include errors but not spans`() {
176172
application.observabilityOptions = getOptionsAllEnabled().copy(
177173
tracesApi = ObservabilityOptions.TracesApi(includeErrors = true, includeSpans = false)

0 commit comments

Comments
 (0)