Commit c21ecd4
authored
fix: Android SR, remove visible scrollbars (#371)
## Summary
Match current iOS padding approach to remove scrollbars
## How did you test this change?
<img width="341" height="451" alt="image"
src="https://github.com/user-attachments/assets/ea004914-3398-488e-866b-fcd1b50b4e08"
/>
## Are there any deployment considerations?
Probably there is more stable way, but this one works
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> **Low Risk**
> Small, localized change to session replay event generation; main risk
is slight coordinate/layout mismatch if consumers assume unpadded
dimensions.
>
> **Overview**
> Adds a fixed `RRWEB_DOCUMENT_PADDING` in `SessionReplayEventGenerator`
and applies it to RRWeb meta sizing and touch coordinates.
>
> `META` events now report `width`/`height` with extra padding, and
interaction events (`ACTION_DOWN`/`MOVE`/`UP`) offset `x`/`y` by the
same amount so replays align with the padded document and avoid visible
scrollbars.
>
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
366da92. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->1 parent 7a17d03 commit c21ecd4
1 file changed
Lines changed: 10 additions & 6 deletions
File tree
- sdk/@launchdarkly/observability-android/lib/src/main/kotlin/com/launchdarkly/observability/replay/exporter
Lines changed: 10 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
25 | 29 | | |
26 | 30 | | |
27 | 31 | | |
| |||
86 | 90 | | |
87 | 91 | | |
88 | 92 | | |
89 | | - | |
90 | | - | |
91 | | - | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
92 | 96 | | |
93 | 97 | | |
94 | 98 | | |
| |||
182 | 186 | | |
183 | 187 | | |
184 | 188 | | |
185 | | - | |
| 189 | + | |
186 | 190 | | |
187 | 191 | | |
188 | 192 | | |
| |||
206 | 210 | | |
207 | 211 | | |
208 | 212 | | |
209 | | - | |
| 213 | + | |
210 | 214 | | |
211 | 215 | | |
212 | 216 | | |
| |||
221 | 225 | | |
222 | 226 | | |
223 | 227 | | |
224 | | - | |
| 228 | + | |
225 | 229 | | |
226 | 230 | | |
227 | 231 | | |
| |||
0 commit comments