Skip to content

fix: Touch move event buffering using wrong clock and mismatched constants#391

Merged
abelonogov-ld merged 4 commits intomainfrom
andrey/move-grouping-fix
Feb 24, 2026
Merged

fix: Touch move event buffering using wrong clock and mismatched constants#391
abelonogov-ld merged 4 commits intomainfrom
andrey/move-grouping-fix

Conversation

@abelonogov-ld
Copy link
Copy Markdown
Contributor

@abelonogov-ld abelonogov-ld commented Feb 24, 2026

Touch move events were ending up in the wrong payload due to two issues in InteractionMoveGrouper:

  • Replaced System.currentTimeMillis() with the touch event's own timestamp parameter, keeping the emit period check on the same monotonic clock as all other time comparisons in the class.
  • Aligned constant values with the iOS implementation to group 4 positions at average during the move

Note

Medium Risk
Changes touch interaction batching thresholds and timing, which can alter replay payload volume/shape and affect downstream ingestion; also disables multiple span-related E2E tests, reducing regression coverage in a telemetry-critical area.

Overview
Fixes touch-move replay buffering in InteractionMoveGrouper by using the MotionEvent-provided timestamp (instead of System.currentTimeMillis()) for emit-period checks so filtering and batching operate on a consistent clock.

Aligns move-grouping constants with iOS (distance/time thresholds and emit period) and updates unit tests to reflect the new thresholds and grouping behavior. Several Android E2E tests asserting span/error export and span sampling are marked @Ignore, effectively removing those checks from CI for now.

Written by Cursor Bugbot for commit 463d050. This will update automatically on new commits. Configure here.

@abelonogov-ld abelonogov-ld requested a review from a team as a code owner February 24, 2026 21:22
@abelonogov-ld abelonogov-ld changed the title fix: touch move event buffering using wrong clock and mismatched constants fix: Touch move event buffering using wrong clock and mismatched constants Feb 24, 2026
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

@abelonogov-ld abelonogov-ld enabled auto-merge (squash) February 24, 2026 22:41
@abelonogov-ld abelonogov-ld merged commit 0a6582c into main Feb 24, 2026
24 checks passed
@abelonogov-ld abelonogov-ld deleted the andrey/move-grouping-fix branch February 24, 2026 22:42
Vadman97 pushed a commit that referenced this pull request Feb 24, 2026
🤖 I have created a release *beep* *boop*
---


<details><summary>launchdarkly-observability-android: 0.26.1</summary>

##
[0.26.1](launchdarkly-observability-android-0.26.0...launchdarkly-observability-android-0.26.1)
(2026-02-24)


### Bug Fixes

* Fix event sorting in session replay export
([#392](#392))
([5e11cf7](5e11cf7))
* Touch move event buffering using wrong clock and mismatched constants
([#391](#391))
([0a6582c](0a6582c))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
abelonogov-ld added a commit that referenced this pull request Feb 25, 2026
…ability-sdk into andrey/mobile-dotnet

* 'andrey/mobile-dotnet' of github.com:launchdarkly/observability-sdk:
  fix: Fix event sorting in session replay export (#392)
  fix: Touch move event buffering using wrong clock and mismatched constants (#391)
abelonogov-ld added a commit that referenced this pull request Feb 27, 2026
* main:
  chore: release main (#396)
  fix: Android span e2e tests (#397)
  fix: improve network response capture (#379)
  feat: initial upload of mobile-dotnet (#393)
  chore: release main (#394)
  fix: Fix event sorting in session replay export (#392)
  fix: Touch move event buffering using wrong clock and mismatched constants (#391)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants