fix: RN iOS distribution#516
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| fi | ||
|
|
||
| # --- Metro --- | ||
| metro_running() { curl -fsS --max-time 1 http://localhost:8081/status 2>/dev/null | grep -q "packager-status:running"; } |
| fi | ||
|
|
||
| # --- Metro --- | ||
| metro_running() { curl -fsS --max-time 1 http://localhost:8081/status 2>/dev/null | grep -q "packager-status:running"; } |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e0e3dda. Configure here.
| end | ||
| agg.user_project.save | ||
| end | ||
| end |
There was a problem hiding this comment.
Scripts directory excluded from npm package distribution
High Severity
The new scripts/podfile_setup.rb file won't be included in the published npm package. The package.json files array lists only src, lib, android, ios, cpp, *.podspec, and react-native.config.js — it does not include scripts. Consumers following the README's require_relative instruction will get a LoadError at pod install time because the file simply won't exist in node_modules.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit e0e3dda. Configure here.
2 participants
Summary
How did you test this change?
Are there any deployment considerations?
Note
Medium Risk
Moderate risk because it changes iOS CocoaPods/Xcode build settings and introduces new consumer-facing Podfile integration, which could impact app build behavior across RN/iOS toolchain variants.
Overview
Improves React Native iOS distribution/build reliability by documenting and shipping Podfile helper hooks (
launchdarkly_sr_pre_install/launchdarkly_sr_post_install) that work around RN 0.83 + Xcode 26 + CocoaPods 1.16.x issues (missing modulemaps, explicit-modules build failures, and low deployment targets).Updates the example app to use these helpers, disables RN CLI automatic pod installation (to avoid Bundler/CocoaPods pinning issues), and adds
run-ios.sh/run-android.shscripts to standardize local development runs.Separately, switches Android observability logging to
LDObserveLogging.adapter(), downgrades the example Gradle wrapper to8.14.3, bumps example iOS pod versions/lockfiles, and removes the example.bundle/config.Reviewed by Cursor Bugbot for commit e0e3dda. Bugbot is set up for automated code reviews on this repo. Configure here.