refactor: remove deprecated ModelResponse, StructuredResponse, AgentResult and compat shims

Author: jsonbailey

packages/sdk/server-ai/src/ldai/__init__.py

@@ -34,7 +34,6 @@
 from ldai.providers import (
     AgentGraphResult,
     AgentGraphRunner,
-    AgentResult,
     AgentRunner,
     ManagedResult,
     Runner,
@@ -49,7 +48,6 @@
     'Evaluator',
     'AgentRunner',
     'AgentGraphRunner',
-    'AgentResult',
     'AgentGraphResult',
     'ManagedResult',
     'Runner',

packages/sdk/server-ai/src/ldai/managed_model.py

@@ -4,7 +4,7 @@
 from ldai import log
 from ldai.models import AICompletionConfig, LDMessage
 from ldai.providers.runner import Runner
-from ldai.providers.types import JudgeResult, ManagedResult
+from ldai.providers.types import JudgeResult, ManagedResult, RunnerResult
 from ldai.tracker import LDAIConfigTracker
 
 
@@ -46,7 +46,7 @@ async def run(self, prompt: str) -> ManagedResult:
         config_messages = self._ai_config.messages or []
         all_messages = config_messages + self._messages
 
-        result = await tracker.track_metrics_of_async(
+        result: RunnerResult = await tracker.track_metrics_of_async(
             lambda r: r.metrics,
             lambda: self._model_runner.run(all_messages),
         )

packages/sdk/server-ai/src/ldai/providers/__init__.py

@@ -6,30 +6,24 @@
 from ldai.providers.runner_factory import RunnerFactory
 from ldai.providers.types import (
     AgentGraphResult,
-    AgentResult,
     JudgeResult,
     LDAIMetrics,
     ManagedResult,
-    ModelResponse,
     RunnerResult,
-    StructuredResponse,
     ToolRegistry,
 )
 
 __all__ = [
     'AIProvider',
     'AgentGraphResult',
     'AgentGraphRunner',
-    'AgentResult',
     'AgentRunner',
     'JudgeResult',
     'LDAIMetrics',
     'ManagedResult',
-    'ModelResponse',
     'ModelRunner',
     'Runner',
     'RunnerFactory',
     'RunnerResult',
-    'StructuredResponse',
     'ToolRegistry',
 ]

packages/sdk/server-ai/src/ldai/providers/agent_runner.py

@@ -1,6 +1,6 @@
 from typing import Any, Protocol, runtime_checkable
 
-from ldai.providers.types import AgentResult
+from ldai.providers.types import RunnerResult
 
 
 @runtime_checkable
@@ -18,11 +18,11 @@ class AgentRunner(Protocol):
     the caller just passes input.
     """
 
-    async def run(self, input: Any) -> AgentResult:
+    async def run(self, input: Any) -> RunnerResult:
         """
         Run the agent with the given input.
 
         :param input: The input to the agent (string prompt or structured input)
-        :return: AgentResult containing the output, raw response, and metrics
+        :return: RunnerResult containing the agent's content, metrics, and optional raw/parsed fields
         """
         ...

packages/sdk/server-ai/src/ldai/providers/ai_provider.py

@@ -1,9 +1,8 @@
 from abc import ABC
-from typing import Any, Dict, List, Optional
+from typing import Any, Optional
 
 from ldai import log
-from ldai.models import LDMessage
-from ldai.providers.types import ModelResponse, StructuredResponse, ToolRegistry
+from ldai.providers.types import ToolRegistry
 
 
 class AIProvider(ABC):
@@ -16,51 +15,6 @@ class AIProvider(ABC):
     create_model(), create_agent(), and create_agent_graph().
     """
 
-    async def invoke_model(self, messages: List[LDMessage]) -> ModelResponse:
-        """
-        Invoke the chat model with an array of messages.
-
-        Default implementation takes no action and returns a placeholder response.
-        Provider implementations should override this method.
-
-        :param messages: Array of LDMessage objects representing the conversation
-        :return: ModelResponse containing the model's response
-        """
-        log.warning('invoke_model not implemented by this provider')
-
-        from ldai.models import LDMessage
-        from ldai.providers.types import LDAIMetrics
-
-        return ModelResponse(
-            message=LDMessage(role='assistant', content=''),
-            metrics=LDAIMetrics(success=False, usage=None),
-        )
-
-    async def invoke_structured_model(
-        self,
-        messages: List[LDMessage],
-        response_structure: Dict[str, Any],
-    ) -> StructuredResponse:
-        """
-        Invoke the chat model with structured output support.
-
-        Default implementation takes no action and returns a placeholder response.
-        Provider implementations should override this method.
-
-        :param messages: Array of LDMessage objects representing the conversation
-        :param response_structure: Dictionary of output configurations keyed by output name
-        :return: StructuredResponse containing the structured data
-        """
-        log.warning('invoke_structured_model not implemented by this provider')
-
-        from ldai.providers.types import LDAIMetrics
-
-        return StructuredResponse(
-            data={},
-            raw_response='',
-            metrics=LDAIMetrics(success=False, usage=None),
-        )
-
     def create_model(self, config: Any) -> Optional[Any]:
         """
         Create a configured model executor for the given AI config.

packages/sdk/server-ai/src/ldai/providers/model_runner.py

@@ -1,7 +1,7 @@
-from typing import Any, Dict, List, Protocol, runtime_checkable
+from typing import List, Protocol, runtime_checkable
 
 from ldai.models import LDMessage
-from ldai.providers.types import ModelResponse, StructuredResponse
+from ldai.providers.types import RunnerResult
 
 
 @runtime_checkable
@@ -14,25 +14,11 @@ class ModelRunner(Protocol):
     and with what parameters — the caller just passes messages.
     """
 
-    async def invoke_model(self, messages: List[LDMessage]) -> ModelResponse:
+    async def invoke_model(self, messages: List[LDMessage]) -> RunnerResult:
         """
         Invoke the model with an array of messages.
 
         :param messages: Array of LDMessage objects representing the conversation
-        :return: ModelResponse containing the model's response and metrics
-        """
-        ...
-
-    async def invoke_structured_model(
-        self,
-        messages: List[LDMessage],
-        response_structure: Dict[str, Any],
-    ) -> StructuredResponse:
-        """
-        Invoke the model with structured output support.
-
-        :param messages: Array of LDMessage objects representing the conversation
-        :param response_structure: Dictionary defining the JSON schema for output structure
-        :return: StructuredResponse containing the structured data
+        :return: RunnerResult containing the model's response and metrics
         """
         ...

packages/sdk/server-ai/src/ldai/providers/types.py

@@ -6,7 +6,6 @@
 from dataclasses import dataclass
 from typing import Any, Callable, Dict, List, Optional
 
-from ldai.models import LDMessage
 from ldai.tracker import LDAIMetricSummary, TokenUsage
 
 # Type alias for a registry of tools available to an agent.
@@ -87,33 +86,6 @@ class ManagedResult:
     """Optional asyncio Task that resolves to the list of :class:`JudgeResult` instances when awaited."""
 
 
-@dataclass
-class ModelResponse:
-    """
-    Response from a model invocation.
-
-    .. deprecated::
-        Use :class:`RunnerResult` (from a runner) and :class:`ManagedResult`
-        (from the managed layer) instead.
-    """
-    message: LDMessage
-    metrics: LDAIMetrics
-    evaluations: Optional[asyncio.Task[List[JudgeResult]]] = None
-
-
-@dataclass
-class StructuredResponse:
-    """
-    Structured response from AI models.
-
-    .. deprecated::
-        Structured output is now represented by :attr:`RunnerResult.parsed`.
-    """
-    data: Dict[str, Any]
-    raw_response: str
-    metrics: LDAIMetrics
-
-
 @dataclass
 class JudgeResult:
     """Contains the result of a single judge evaluation."""
@@ -160,20 +132,6 @@ def to_dict(self) -> Dict[str, Any]:
         return result
 
 
-@dataclass
-class AgentResult:
-    """
-    Result from a single-agent run.
-
-    .. deprecated::
-        Use :class:`ManagedResult` (managed layer) or :class:`RunnerResult`
-        (runner layer) instead.
-    """
-    output: str
-    raw: Any
-    metrics: LDAIMetrics
-
-
 @dataclass
 class AgentGraphResult:
     """Contains the result of an agent graph run."""

packages/sdk/server-ai/tests/test_managed_model.py

@@ -56,7 +56,7 @@ async def test_run_returns_managed_result(self):
         )
 
         mock_runner = MagicMock()
-        mock_runner.invoke_model = AsyncMock(return_value=_make_runner_result('hi'))
+        mock_runner.run = AsyncMock(return_value=_make_runner_result('hi'))
 
         mock_tracker = MagicMock(spec=LDAIConfigTracker)
         mock_tracker.track_metrics_of_async = AsyncMock(return_value=_make_runner_result('hi'))
@@ -96,7 +96,7 @@ async def _slow_evaluate(input_text: str, output_text: str) -> List[JudgeResult]
         )
 
         mock_runner = MagicMock()
-        mock_runner.invoke_model = AsyncMock(return_value=_make_runner_result())
+        mock_runner.run = AsyncMock(return_value=_make_runner_result())
 
         config, _tracker = _make_config_with_tracker(evaluator)
         model = ManagedModel(config, mock_runner)
@@ -130,7 +130,7 @@ async def _evaluate_coro(input_text: str, output_text: str) -> List[JudgeResult]
         )
 
         mock_runner = MagicMock()
-        mock_runner.invoke_model = AsyncMock(return_value=_make_runner_result())
+        mock_runner.run = AsyncMock(return_value=_make_runner_result())
 
         config, _tracker = _make_config_with_tracker(evaluator)
         model = ManagedModel(config, mock_runner)
@@ -160,7 +160,7 @@ async def _evaluate_coro(input_text: str, output_text: str) -> List[JudgeResult]
         )
 
         mock_runner = MagicMock()
-        mock_runner.invoke_model = AsyncMock(return_value=_make_runner_result())
+        mock_runner.run = AsyncMock(return_value=_make_runner_result())
 
         config, mock_tracker = _make_config_with_tracker(evaluator)
         mock_tracker.track_judge_result = MagicMock()
@@ -195,7 +195,7 @@ async def _evaluate_coro(input_text: str, output_text: str) -> List[JudgeResult]
         )
 
         mock_runner = MagicMock()
-        mock_runner.invoke_model = AsyncMock(return_value=_make_runner_result())
+        mock_runner.run = AsyncMock(return_value=_make_runner_result())
 
         config, mock_tracker = _make_config_with_tracker(evaluator)
         mock_tracker.track_judge_result = MagicMock()
@@ -212,7 +212,7 @@ async def test_noop_evaluator_returns_empty_list(self):
         evaluator = Evaluator.noop()
 
         mock_runner = MagicMock()
-        mock_runner.invoke_model = AsyncMock(return_value=_make_runner_result())
+        mock_runner.run = AsyncMock(return_value=_make_runner_result())
 
         config, _tracker = _make_config_with_tracker(evaluator)
         model = ManagedModel(config, mock_runner)