Skip to content

Commit 133bc10

Browse files
jsonbaileyclaude
andcommitted
fix: update runner tests to pass str to run() instead of list[LDMessage]
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 1e8194f commit 133bc10

2 files changed

Lines changed: 13 additions & 28 deletions

File tree

packages/ai-providers/server-ai-langchain/tests/test_langchain_provider.py

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -233,8 +233,7 @@ async def test_returns_success_true_for_string_content(self, mock_llm):
233233
mock_llm.ainvoke = AsyncMock(return_value=mock_response)
234234
provider = LangChainModelRunner(mock_llm)
235235

236-
messages = [LDMessage(role='user', content='Hello')]
237-
result = await provider.run(messages)
236+
result = await provider.run('Hello')
238237

239238
assert result.metrics.success is True
240239
assert result.content == 'Test response'
@@ -246,8 +245,7 @@ async def test_returns_success_false_for_non_string_content_and_logs_warning(sel
246245
mock_llm.ainvoke = AsyncMock(return_value=mock_response)
247246
provider = LangChainModelRunner(mock_llm)
248247

249-
messages = [LDMessage(role='user', content='Hello')]
250-
result = await provider.run(messages)
248+
result = await provider.run('Hello')
251249

252250
assert result.metrics.success is False
253251
assert result.content == ''
@@ -259,8 +257,7 @@ async def test_returns_success_false_when_model_invocation_throws_error(self, mo
259257
mock_llm.ainvoke = AsyncMock(side_effect=error)
260258
provider = LangChainModelRunner(mock_llm)
261259

262-
messages = [LDMessage(role='user', content='Hello')]
263-
result = await provider.run(messages)
260+
result = await provider.run('Hello')
264261

265262
assert result.metrics.success is False
266263
assert result.content == ''
@@ -284,9 +281,8 @@ async def test_returns_success_true_for_successful_invocation(self, mock_llm):
284281
mock_llm.with_structured_output = MagicMock(return_value=mock_structured_llm)
285282
provider = LangChainModelRunner(mock_llm)
286283

287-
messages = [LDMessage(role='user', content='Hello')]
288284
response_structure = {'type': 'object', 'properties': {}}
289-
result = await provider.run(messages, output_type=response_structure)
285+
result = await provider.run('Hello', output_type=response_structure)
290286

291287
assert result.metrics.success is True
292288
assert result.parsed == parsed_data
@@ -300,9 +296,8 @@ async def test_returns_success_false_when_structured_model_invocation_throws_err
300296
mock_llm.with_structured_output = MagicMock(return_value=mock_structured_llm)
301297
provider = LangChainModelRunner(mock_llm)
302298

303-
messages = [LDMessage(role='user', content='Hello')]
304299
response_structure = {'type': 'object', 'properties': {}}
305-
result = await provider.run(messages, output_type=response_structure)
300+
result = await provider.run('Hello', output_type=response_structure)
306301

307302
assert result.metrics.success is False
308303
assert result.parsed is None

packages/ai-providers/server-ai-openai/tests/test_openai_provider.py

Lines changed: 8 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44
from typing import Any
55
from unittest.mock import AsyncMock, MagicMock, patch
66

7-
from ldai import LDMessage
8-
97
from ldai_openai import OpenAIModelRunner, OpenAIRunnerFactory, get_ai_metrics_from_response, get_ai_usage_from_response
108

119

@@ -143,8 +141,7 @@ async def test_invokes_openai_chat_completions_and_returns_response(self, mock_c
143141
mock_client.chat.completions.create = AsyncMock(return_value=mock_response)
144142

145143
provider = OpenAIModelRunner(mock_client, 'gpt-3.5-turbo', {})
146-
messages = [LDMessage(role='user', content='Hello!')]
147-
result = await provider.run(messages)
144+
result = await provider.run('Hello!')
148145

149146
mock_client.chat.completions.create.assert_called_once_with(
150147
model='gpt-3.5-turbo',
@@ -172,8 +169,7 @@ async def test_returns_unsuccessful_response_when_no_content(self, mock_client):
172169
mock_client.chat.completions.create = AsyncMock(return_value=mock_response)
173170

174171
provider = OpenAIModelRunner(mock_client, 'gpt-3.5-turbo', {})
175-
messages = [LDMessage(role='user', content='Hello!')]
176-
result = await provider.run(messages)
172+
result = await provider.run('Hello!')
177173

178174
assert result.content == ''
179175
assert result.metrics.success is False
@@ -190,8 +186,7 @@ async def test_returns_unsuccessful_response_when_choices_empty(self, mock_clien
190186
mock_client.chat.completions.create = AsyncMock(return_value=mock_response)
191187

192188
provider = OpenAIModelRunner(mock_client, 'gpt-3.5-turbo', {})
193-
messages = [LDMessage(role='user', content='Hello!')]
194-
result = await provider.run(messages)
189+
result = await provider.run('Hello!')
195190

196191
assert result.content == ''
197192
assert result.metrics.success is False
@@ -204,8 +199,7 @@ async def test_returns_unsuccessful_response_when_exception_thrown(self, mock_cl
204199
mock_client.chat.completions.create = AsyncMock(side_effect=Exception('API Error'))
205200

206201
provider = OpenAIModelRunner(mock_client, 'gpt-3.5-turbo', {})
207-
messages = [LDMessage(role='user', content='Hello!')]
208-
result = await provider.run(messages)
202+
result = await provider.run('Hello!')
209203

210204
assert result.content == ''
211205
assert result.metrics.success is False
@@ -234,7 +228,6 @@ async def test_invokes_openai_with_structured_output(self, mock_client):
234228
mock_client.chat.completions.create = AsyncMock(return_value=mock_response)
235229

236230
provider = OpenAIModelRunner(mock_client, 'gpt-3.5-turbo', {})
237-
messages = [LDMessage(role='user', content='Tell me about a person')]
238231
response_structure = {
239232
'type': 'object',
240233
'properties': {
@@ -245,7 +238,7 @@ async def test_invokes_openai_with_structured_output(self, mock_client):
245238
'required': ['name', 'age', 'city'],
246239
}
247240

248-
result = await provider.run(messages, output_type=response_structure)
241+
result = await provider.run('Tell me about a person', output_type=response_structure)
249242

250243
assert result.parsed == {'name': 'John', 'age': 30, 'city': 'New York'}
251244
assert result.content == '{"name": "John", "age": 30, "city": "New York"}'
@@ -269,10 +262,9 @@ async def test_returns_unsuccessful_when_no_content_in_structured_response(self,
269262
mock_client.chat.completions.create = AsyncMock(return_value=mock_response)
270263

271264
provider = OpenAIModelRunner(mock_client, 'gpt-3.5-turbo', {})
272-
messages = [LDMessage(role='user', content='Tell me about a person')]
273265
response_structure = {'type': 'object'}
274266

275-
result = await provider.run(messages, output_type=response_structure)
267+
result = await provider.run('Tell me about a person', output_type=response_structure)
276268

277269
assert result.parsed is None
278270
assert result.content == ''
@@ -293,10 +285,9 @@ async def test_handles_json_parsing_errors(self, mock_client):
293285
mock_client.chat.completions.create = AsyncMock(return_value=mock_response)
294286

295287
provider = OpenAIModelRunner(mock_client, 'gpt-3.5-turbo', {})
296-
messages = [LDMessage(role='user', content='Tell me about a person')]
297288
response_structure = {'type': 'object'}
298289

299-
result = await provider.run(messages, output_type=response_structure)
290+
result = await provider.run('Tell me about a person', output_type=response_structure)
300291

301292
assert result.parsed is None
302293
assert result.content == 'invalid json content'
@@ -312,10 +303,9 @@ async def test_returns_unsuccessful_response_when_exception_thrown(self, mock_cl
312303
mock_client.chat.completions.create = AsyncMock(side_effect=Exception('API Error'))
313304

314305
provider = OpenAIModelRunner(mock_client, 'gpt-3.5-turbo', {})
315-
messages = [LDMessage(role='user', content='Tell me about a person')]
316306
response_structure = {'type': 'object'}
317307

318-
result = await provider.run(messages, output_type=response_structure)
308+
result = await provider.run('Tell me about a person', output_type=response_structure)
319309

320310
assert result.parsed is None
321311
assert result.content == ''

0 commit comments

Comments
 (0)