Skip to content

Commit 1f26956

Browse files
jsonbaileyclaude
andcommitted
fix: update ManagedModel tests to mock runner.run instead of invoke_model
ManagedModel.run() calls self._model_runner.run(), not invoke_model. The previous mocks were dead code that never exercised the runner. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent e2e2b6e commit 1f26956

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

packages/sdk/server-ai/tests/test_managed_model.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ async def test_run_returns_managed_result(self):
5656
)
5757

5858
mock_runner = MagicMock()
59-
mock_runner.invoke_model = AsyncMock(return_value=_make_runner_result('hi'))
59+
mock_runner.run = AsyncMock(return_value=_make_runner_result('hi'))
6060

6161
mock_tracker = MagicMock(spec=LDAIConfigTracker)
6262
mock_tracker.track_metrics_of_async = AsyncMock(return_value=_make_runner_result('hi'))
@@ -96,7 +96,7 @@ async def _slow_evaluate(input_text: str, output_text: str) -> List[JudgeResult]
9696
)
9797

9898
mock_runner = MagicMock()
99-
mock_runner.invoke_model = AsyncMock(return_value=_make_runner_result())
99+
mock_runner.run = AsyncMock(return_value=_make_runner_result())
100100

101101
config, _tracker = _make_config_with_tracker(evaluator)
102102
model = ManagedModel(config, mock_runner)
@@ -130,7 +130,7 @@ async def _evaluate_coro(input_text: str, output_text: str) -> List[JudgeResult]
130130
)
131131

132132
mock_runner = MagicMock()
133-
mock_runner.invoke_model = AsyncMock(return_value=_make_runner_result())
133+
mock_runner.run = AsyncMock(return_value=_make_runner_result())
134134

135135
config, _tracker = _make_config_with_tracker(evaluator)
136136
model = ManagedModel(config, mock_runner)
@@ -160,7 +160,7 @@ async def _evaluate_coro(input_text: str, output_text: str) -> List[JudgeResult]
160160
)
161161

162162
mock_runner = MagicMock()
163-
mock_runner.invoke_model = AsyncMock(return_value=_make_runner_result())
163+
mock_runner.run = AsyncMock(return_value=_make_runner_result())
164164

165165
config, mock_tracker = _make_config_with_tracker(evaluator)
166166
mock_tracker.track_judge_result = MagicMock()
@@ -195,7 +195,7 @@ async def _evaluate_coro(input_text: str, output_text: str) -> List[JudgeResult]
195195
)
196196

197197
mock_runner = MagicMock()
198-
mock_runner.invoke_model = AsyncMock(return_value=_make_runner_result())
198+
mock_runner.run = AsyncMock(return_value=_make_runner_result())
199199

200200
config, mock_tracker = _make_config_with_tracker(evaluator)
201201
mock_tracker.track_judge_result = MagicMock()
@@ -212,7 +212,7 @@ async def test_noop_evaluator_returns_empty_list(self):
212212
evaluator = Evaluator.noop()
213213

214214
mock_runner = MagicMock()
215-
mock_runner.invoke_model = AsyncMock(return_value=_make_runner_result())
215+
mock_runner.run = AsyncMock(return_value=_make_runner_result())
216216

217217
config, _tracker = _make_config_with_tracker(evaluator)
218218
model = ManagedModel(config, mock_runner)

0 commit comments

Comments
 (0)