Skip to content

Commit 2d80afe

Browse files
committed
fix: log judge initialization failures in _create_judge_instance; remove dead except in _build_evaluator
1 parent 7365be2 commit 2d80afe

1 file changed

Lines changed: 12 additions & 15 deletions

File tree

packages/sdk/server-ai/src/ldai/client.py

Lines changed: 12 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -340,7 +340,8 @@ def _create_judge_instance(
340340
return None
341341

342342
return Judge(judge_config, provider, sample_rate=sample_rate)
343-
except Exception:
343+
except Exception as e:
344+
log.warning('Failed to initialize judge %r: %s', key, e)
344345
return None
345346

346347
def _build_evaluator(
@@ -364,20 +365,16 @@ def _build_evaluator(
364365
return Evaluator.noop()
365366
judge_instances: List[Judge] = []
366367
for jc in judge_configuration.judges:
367-
try:
368-
judge = self._create_judge_instance(
369-
jc.key,
370-
context,
371-
AIJudgeConfigDefault.disabled(),
372-
variables,
373-
default_ai_provider,
374-
sample_rate=jc.sampling_rate,
375-
)
376-
if judge is not None:
377-
judge_instances.append(judge)
378-
except Exception as e:
379-
log.warning(f'Failed to initialize judge {jc.key!r}: {e}')
380-
continue
368+
judge = self._create_judge_instance(
369+
jc.key,
370+
context,
371+
AIJudgeConfigDefault.disabled(),
372+
variables,
373+
default_ai_provider,
374+
sample_rate=jc.sampling_rate,
375+
)
376+
if judge is not None:
377+
judge_instances.append(judge)
381378
return Evaluator(judge_instances)
382379

383380
async def create_model(

0 commit comments

Comments
 (0)