adjust how we set tool type

Author: jsonbailey

packages/ai-providers/server-ai-openai/src/ldai_openai/openai_helper.py

@@ -78,8 +78,7 @@ def get_ai_metrics_from_response(response: Any) -> LDAIMetrics:
     return LDAIMetrics(success=True, usage=get_ai_usage_from_response(response))
 
 
-# Tool names that require their own API type in the Chat Completions API.
-# LD stores all tools as type="function"; these are converted to their correct type.
+# Tool ``name`` values that map to OpenAI hosted-tool ``type`` (same string as ``name``).
 _NATIVE_API_TOOL_NAMES = frozenset({
     'web_search',
     'file_search',
@@ -89,11 +88,12 @@ def get_ai_metrics_from_response(response: Any) -> LDAIMetrics:
 
 def normalize_tool_types(tool_definitions: List[Any]) -> List[Dict[str, Any]]:
     """
-    Convert LD tool definitions to Chat Completions API format.
+    Set ``type`` on LD tool definitions for OpenAI hosted tools.
 
-    LD emits all tools as ``type="function"`` with a flat structure. This helper
-    wraps regular function tools in the nested ``function`` key the API requires,
-    and converts known native tool names to their correct API type without a schema.
+    When ``name`` is a known OpenAI hosted tool (e.g. ``file_search``), ``type`` is set
+    to that name; all other keys are left unchanged (``vector_store_ids``, etc.
+    come from the LD config). Other tools and non-dict entries are passed through
+    unchanged (non-dicts are skipped).
 
     :param tool_definitions: Tool definitions from the LD AI config
     :return: Tool list ready to pass to ``chat.completions.create``
@@ -103,7 +103,10 @@ def normalize_tool_types(tool_definitions: List[Any]) -> List[Dict[str, Any]]:
         if not isinstance(td, dict):
             continue
         name = td.get('name', '')
-        result.append({**td, 'type': name} if name in _NATIVE_API_TOOL_NAMES else td)
+        if name in _NATIVE_API_TOOL_NAMES:
+            result.append({**td, 'type': name})
+        else:
+            result.append(td)
     return result
 
 

packages/ai-providers/server-ai-openai/src/ldai_openai/openai_runner_factory.py

@@ -85,8 +85,8 @@ def create_model(self, config: AIConfigKind) -> OpenAIModelRunner:
         Create a configured OpenAIModelRunner for the given AI config.
 
         Reuses the underlying AsyncOpenAI client so connection pooling is preserved.
-        Tool definitions are converted from LD's flat format to the Chat Completions
-        API format, with native tools mapped to their correct API type.
+        Hosted tool definitions have ``type`` adjusted from LD's placeholder when
+        needed; all other fields are passed through from the config.
 
         :param config: The LaunchDarkly AI configuration
         :return: OpenAIModelRunner ready to invoke the model