Commit 42fe82c
fix: eliminate fire-and-forget tasks and harden eval task tracking
- Redesign ManagedModel._track_judge_results to call evaluator.evaluate()
internally and attach tracking via add_done_callback, returning the task
so the reference is held by ModelResponse.evaluations — no GC risk
- Warn instead of silently dropping eval tasks when the LangGraph ContextVar
is unexpectedly unset in a node's execution context
- Make AgentGraphDefinition.create_tracker a required parameter; all
production and test call sites already supply it, and this matches the
invariant that runners only execute on enabled (always-tracked) graphs
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>1 parent b65dd04 commit 42fe82c
4 files changed
Lines changed: 28 additions & 11 deletions
File tree
- packages
- ai-providers/server-ai-langchain
- src/ldai_langchain
- tests
- sdk/server-ai/src/ldai
- agent_graph
Lines changed: 8 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
192 | 192 | | |
193 | 193 | | |
194 | 194 | | |
195 | | - | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
196 | 203 | | |
197 | 204 | | |
198 | 205 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
433 | 433 | | |
434 | 434 | | |
435 | 435 | | |
436 | | - | |
| 436 | + | |
437 | 437 | | |
438 | 438 | | |
439 | 439 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
55 | | - | |
| 55 | + | |
56 | 56 | | |
57 | 57 | | |
58 | 58 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
52 | | - | |
53 | 52 | | |
54 | 53 | | |
55 | | - | |
56 | | - | |
| 54 | + | |
57 | 55 | | |
58 | 56 | | |
59 | 57 | | |
60 | 58 | | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
65 | 73 | | |
66 | 74 | | |
67 | | - | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
68 | 78 | | |
69 | 79 | | |
70 | 80 | | |
| |||
0 commit comments