Skip to content

Commit 677e790

Browse files
jsonbaileyclaude
andcommitted
refactor: Make _track_judge_results async to signal loop requirement
The method constructs and returns an asyncio.Task via asyncio.create_task(), which requires a running event loop. It doesn't itself await anything, but marking it async documents the loop requirement at the signature level and prevents accidental sync callers from getting a runtime "no running event loop" error. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent c17ac2d commit 677e790

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

packages/sdk/server-ai/src/ldai/managed_agent.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ async def run(self, input: str) -> ManagedResult:
4545
lambda: self._agent_runner.run(input),
4646
)
4747

48-
evaluations_task = self._track_judge_results(tracker, input, result.content)
48+
evaluations_task = await self._track_judge_results(tracker, input, result.content)
4949

5050
return ManagedResult(
5151
content=result.content,
@@ -54,7 +54,7 @@ async def run(self, input: str) -> ManagedResult:
5454
evaluations=evaluations_task,
5555
)
5656

57-
def _track_judge_results(
57+
async def _track_judge_results(
5858
self,
5959
tracker: LDAIConfigTracker,
6060
input_text: str,

packages/sdk/server-ai/src/ldai/managed_model.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ async def run(self, prompt: str) -> ManagedResult:
4444
lambda: self._model_runner.run(prompt),
4545
)
4646

47-
evaluations_task = self._track_judge_results(tracker, prompt, result.content)
47+
evaluations_task = await self._track_judge_results(tracker, prompt, result.content)
4848

4949
return ManagedResult(
5050
content=result.content,
@@ -54,7 +54,7 @@ async def run(self, prompt: str) -> ManagedResult:
5454
evaluations=evaluations_task,
5555
)
5656

57-
def _track_judge_results(
57+
async def _track_judge_results(
5858
self,
5959
tracker: LDAIConfigTracker,
6060
input_text: str,

0 commit comments

Comments
 (0)