Remove unnecessary one shot restrictions

Author: jsonbailey

packages/sdk/server-ai/src/ldai/tracker.py

@@ -51,7 +51,7 @@ def __init__(self):
         self._feedback: Optional[Dict[str, FeedbackKind]] = None
         self._usage: Optional[TokenUsage] = None
         self._time_to_first_token: Optional[int] = None
-        self._tool_calls: Optional[List[str]] = None
+        self._tool_calls: List[str] = []
         self._resumption_token: Optional[str] = None
 
     @property
@@ -89,7 +89,7 @@ def time_to_first_token(self) -> Optional[int]:
         return self._time_to_first_token
 
     @property
-    def tool_calls(self) -> Optional[List[str]]:
+    def tool_calls(self) -> List[str]:
         """List of tool keys that were invoked during this operation."""
         return self._tool_calls
 
@@ -429,16 +429,13 @@ def track_tool_calls(self, tool_calls: Iterable[str]) -> None:
         """
         Track the tool calls made during an AI operation.
 
-        Stores the tool call names on the summary (guarding against duplicate
-        tracking) and fires a ``$ld:ai:tool_call`` event for each tool.
+        Appends to the summary's tool call list and fires a
+        ``$ld:ai:tool_call`` event for each tool.
 
         :param tool_calls: Tool identifiers (e.g. from a model response).
         """
-        if self._summary.tool_calls is not None:
-            log.warning("Tool calls have already been tracked for this execution. %s", self.__get_track_data())
-            return
         tool_calls_list = list(tool_calls)
-        self._summary._tool_calls = tool_calls_list
+        self._summary._tool_calls.extend(tool_calls_list)
         for tool_key in tool_calls_list:
             self.track_tool_call(tool_key)
 
@@ -749,12 +746,12 @@ def track_path(self, path: List[str]) -> None:
         """
         Track the execution path through the graph.
 
+        Appends to the summary's path list and fires a ``$ld:ai:graph:path``
+        event. Can be called multiple times to build the path incrementally.
+
         :param path: An array of configuration keys representing the sequence of nodes executed during graph traversal.
         """
-        if self._summary.path:
-            log.warning("Path has already been tracked for this graph execution. %s", self.__get_track_data())
-            return
-        self._summary.path = list(path)
+        self._summary.path.extend(path)
         track_data = {**self.__get_track_data(), "path": path}
         self._ld_client.track(
             "$ld:ai:graph:path",

packages/sdk/server-ai/tests/test_tracker.py

@@ -636,14 +636,14 @@ def test_ai_graph_tracker_duplicate_success_is_ignored(client: LDClient):
     assert g.get_summary().success is True
 
 
-def test_ai_graph_tracker_duplicate_path_is_ignored(client: LDClient):
+def test_ai_graph_tracker_path_accumulates(client: LDClient):
     context = Context.create("user-key")
     g = AIGraphTracker(client, "variation-key", "graph-key", 2, context)
     g.track_path(["a", "b"])
     g.track_path(["x", "y", "z"])
     path_calls = [c for c in client.track.mock_calls if c.args[0] == "$ld:ai:graph:path"]  # type: ignore
-    assert len(path_calls) == 1
-    assert g.get_summary().path == ["a", "b"]
+    assert len(path_calls) == 2
+    assert g.get_summary().path == ["a", "b", "x", "y", "z"]
 
 
 def test_ai_graph_tracker_duplicate_tokens_is_ignored(client: LDClient):
@@ -1236,6 +1236,23 @@ def extract(_r):
     assert len(tool_call_events) == 2
 
 
+def test_track_tool_calls_accumulates(client: LDClient):
+    context = Context.create("user-key")
+    tracker = LDAIConfigTracker(
+        ld_client=client, run_id="test-run-id", config_key="config-key",
+        variation_key="variation-key", version=3, model_name="m",
+        provider_name="p", context=context,
+    )
+    tracker.track_tool_calls(["foo", "bar"])
+    tracker.track_tool_calls(["baz"])
+    assert tracker.get_summary().tool_calls == ["foo", "bar", "baz"]
+    tool_call_events = [
+        c for c in client.track.mock_calls  # type: ignore
+        if c.args[0] == "$ld:ai:tool_call"
+    ]
+    assert len(tool_call_events) == 3
+
+
 def test_track_metrics_of_skips_track_tool_calls_when_absent(client: LDClient):
     context = Context.create("user-key")
     tracker = LDAIConfigTracker(
@@ -1251,7 +1268,7 @@ def extract(_r):
         return LDAIMetrics(success=True, usage=None)
 
     tracker.track_metrics_of(extract, fn)
-    assert tracker.get_summary().tool_calls is None
+    assert tracker.get_summary().tool_calls == []
     tool_call_events = [
         c for c in client.track.mock_calls  # type: ignore
         if c.args[0] == "$ld:ai:tool_call"