chore: cursor feedback, remove unnecessary log of response

Author: andrewklatzke

packages/optimization/src/ldai_optimizer/client.py

@@ -185,7 +185,7 @@ def _initialize_class_members_from_config(
         self._history: List[OptimizationContext] = []
 
     def _build_agent_config_for_context(
-        self, ctx: OptimizationContext
+        self, ctx: OptimizationContext, skip_interpolation: bool = False
     ) -> AIAgentConfig:
         """
         Construct an AIAgentConfig that reflects the current optimization iteration.
@@ -196,16 +196,21 @@ def _build_agent_config_for_context(
         ctx.current_variables at call time so the stored template is never mutated.
 
         :param ctx: The OptimizationContext for this iteration
+        :param skip_interpolation: When True, skip variable interpolation on the
+            instructions. Use this when the instructions are a meta-prompt (e.g. a
+            variation-generation prompt) that deliberately contains ``{{key}}`` tokens
+            as text for the LLM to read rather than as runtime substitution targets.
         :return: A fresh AIAgentConfig populated from the context's current state
         """
         instructions = (
             interpolate_variables(ctx.current_instructions, ctx.current_variables)
-            if ctx.current_variables
+            if ctx.current_variables and not skip_interpolation
             else ctx.current_instructions
         )
         return AIAgentConfig(
             key=self._agent_key,
             enabled=True,
+            create_tracker=self._agent_config.create_tracker,
             model=ModelConfig(
                 name=ctx.current_model or "",
                 parameters=ctx.current_parameters,
@@ -1330,7 +1335,7 @@ async def _generate_new_variation(
         # Retry up to _MAX_VARIATION_RETRIES times to handle transient empty or unparseable
         # responses (e.g. when the agent SDK returns the LLM's post-tool-call empty text
         # instead of the tool result).
-        agent_config = self._build_agent_config_for_context(variation_ctx)
+        agent_config = self._build_agent_config_for_context(variation_ctx, skip_interpolation=True)
         response_data = None
         response_str = ""
         for attempt in range(1, _MAX_VARIATION_RETRIES + 1):

packages/optimization/src/ldai_optimizer/util.py

@@ -323,10 +323,18 @@ def extract_json_from_response(response_str: str) -> Dict[str, Any]:
 
     # Try balanced-brace scanning
     if response_data is None:
-        brace_count = 0
         start_idx = response_str.find('{')
         if start_idx != -1:
-            for i in range(start_idx, len(response_str)):
+            logger.warning(
+                "Direct JSON parse and code-block extraction failed; "
+                "falling back to balanced-brace scanner. "
+                "Response may be malformed JSON (length: %d).",
+                len(response_str),
+            )
+        while start_idx != -1 and response_data is None:
+            brace_count = 0
+            i = start_idx
+            while i < len(response_str):
                 if response_str[i] == '{':
                     brace_count += 1
                 elif response_str[i] == '}':
@@ -335,12 +343,13 @@ def extract_json_from_response(response_str: str) -> Dict[str, Any]:
                         json_str = response_str[start_idx:i + 1]
                         try:
                             response_data = json.loads(json_str)
-                            break
                         except json.JSONDecodeError:
                             start_idx = response_str.find('{', start_idx + 1)
-                            if start_idx == -1:
-                                break
-                            brace_count = 0
+                        break
+                i += 1
+            else:
+                # Exhausted the string without closing the object
+                break
 
     # Legacy regex fallback
     if response_data is None:
@@ -364,9 +373,8 @@ def extract_json_from_response(response_str: str) -> Dict[str, Any]:
     if response_data is None:
         logger.debug(
             "Failed to extract JSON from response. "
-            "Response length: %d, response: %s",
+            "Response length: %d",
             len(response_str),
-            response_str,
         )
         raise ValueError(
             "Failed to parse structured output from variation generation. "

packages/optimization/tests/test_client.py

@@ -62,6 +62,7 @@ def _make_agent_config(
     return AIAgentConfig(
         key="test-agent",
         enabled=True,
+        create_tracker=MagicMock,
         model=ModelConfig(name=model_name, parameters=parameters or {}),
         instructions=instructions,
     )
@@ -679,6 +680,7 @@ def _make_judge_config(self, enabled: bool = True) -> AIJudgeConfig:
         return AIJudgeConfig(
             key="ld-judge-key",
             enabled=enabled,
+            create_tracker=MagicMock,
             model=ModelConfig(name="gpt-4o", parameters={}),
             messages=[
                 LDMessage(role="system", content="You are an evaluator."),
@@ -782,6 +784,7 @@ async def test_returns_zero_score_when_judge_has_no_messages(self):
         judge_config = AIJudgeConfig(
             key="ld-judge-key",
             enabled=True,
+            create_tracker=MagicMock,
             model=ModelConfig(name="gpt-4o", parameters={}),
             messages=None,
         )