Skip to content

Commit 7a40d96

Browse files
keelerm84keelerm84
committed
ci: simplify for attestation-only releases (no draft needed)
Since actions/attest@v4 stores attestations via GitHub's attestation API (not as release assets), repos that only use attestation don't need draft releases. Release-please can publish the release directly. Changes: - Remove draft:true from release-please-config.json - Remove create-tag job/steps (force-tag-creation handles this) - Remove publish-release job (release is published directly) - Remove publish_release input from manual workflows
1 parent 49a59a4 commit 7a40d96

2 files changed

Lines changed: 0 additions & 111 deletions

File tree

‎.github/workflows/release-please.yml‎

Lines changed: 0 additions & 107 deletions
Original file line numberDiff line numberDiff line change
@@ -66,21 +66,6 @@ jobs:
6666
with:
6767
fetch-depth: 0
6868

69-
- name: Create release tag
70-
env:
71-
TAG_NAME: ${{ needs.release-please.outputs.package-server-ai-tag-name }}
72-
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
73-
run: |
74-
if gh api "repos/${{ github.repository }}/git/ref/tags/${TAG_NAME}" >/dev/null 2>&1; then
75-
echo "Tag ${TAG_NAME} already exists, skipping creation."
76-
else
77-
echo "Creating tag ${TAG_NAME}."
78-
git config user.name "github-actions[bot]"
79-
git config user.email "github-actions[bot]@users.noreply.github.com"
80-
git tag "${TAG_NAME}"
81-
git push origin "${TAG_NAME}"
82-
fi
83-
8469
- uses: ./.github/actions/ci
8570
with:
8671
workspace_path: packages/sdk/server-ai
@@ -126,21 +111,6 @@ jobs:
126111
with:
127112
fetch-depth: 0
128113

129-
- name: Create release tag
130-
env:
131-
TAG_NAME: ${{ needs.release-please.outputs.package-server-ai-langchain-tag-name }}
132-
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
133-
run: |
134-
if gh api "repos/${{ github.repository }}/git/ref/tags/${TAG_NAME}" >/dev/null 2>&1; then
135-
echo "Tag ${TAG_NAME} already exists, skipping creation."
136-
else
137-
echo "Creating tag ${TAG_NAME}."
138-
git config user.name "github-actions[bot]"
139-
git config user.email "github-actions[bot]@users.noreply.github.com"
140-
git tag "${TAG_NAME}"
141-
git push origin "${TAG_NAME}"
142-
fi
143-
144114
- uses: ./.github/actions/ci
145115
with:
146116
workspace_path: packages/ai-providers/server-ai-langchain
@@ -218,21 +188,6 @@ jobs:
218188
with:
219189
fetch-depth: 0
220190

221-
- name: Create release tag
222-
env:
223-
TAG_NAME: ${{ needs.release-please.outputs.package-server-ai-openai-tag-name }}
224-
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
225-
run: |
226-
if gh api "repos/${{ github.repository }}/git/ref/tags/${TAG_NAME}" >/dev/null 2>&1; then
227-
echo "Tag ${TAG_NAME} already exists, skipping creation."
228-
else
229-
echo "Creating tag ${TAG_NAME}."
230-
git config user.name "github-actions[bot]"
231-
git config user.email "github-actions[bot]@users.noreply.github.com"
232-
git tag "${TAG_NAME}"
233-
git push origin "${TAG_NAME}"
234-
fi
235-
236191
- uses: ./.github/actions/ci
237192
with:
238193
workspace_path: packages/ai-providers/server-ai-openai
@@ -278,21 +233,6 @@ jobs:
278233
with:
279234
fetch-depth: 0
280235

281-
- name: Create release tag
282-
env:
283-
TAG_NAME: ${{ needs.release-please.outputs.package-server-ai-optimization-tag-name }}
284-
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
285-
run: |
286-
if gh api "repos/${{ github.repository }}/git/ref/tags/${TAG_NAME}" >/dev/null 2>&1; then
287-
echo "Tag ${TAG_NAME} already exists, skipping creation."
288-
else
289-
echo "Creating tag ${TAG_NAME}."
290-
git config user.name "github-actions[bot]"
291-
git config user.email "github-actions[bot]@users.noreply.github.com"
292-
git tag "${TAG_NAME}"
293-
git push origin "${TAG_NAME}"
294-
fi
295-
296236
- uses: ./.github/actions/ci
297237
with:
298238
workspace_path: packages/optimization
@@ -324,50 +264,3 @@ jobs:
324264
with:
325265
password: ${{ env.PYPI_AUTH_TOKEN }}
326266
packages-dir: packages/optimization/dist/
327-
328-
publish-release:
329-
needs: ['release-please', 'release-server-ai', 'release-server-ai-langchain', 'release-server-ai-openai', 'release-server-ai-optimization']
330-
if: ${{ always() && needs.release-please.result == 'success' && (needs.release-please.outputs.package-server-ai-released == 'true' || needs.release-please.outputs.package-server-ai-langchain-released == 'true' || needs.release-please.outputs.package-server-ai-openai-released == 'true' || needs.release-please.outputs.package-server-ai-optimization-released == 'true') }}
331-
runs-on: ubuntu-latest
332-
permissions:
333-
contents: write
334-
steps:
335-
- name: Publish server-ai release
336-
if: ${{ needs.release-please.outputs.package-server-ai-released == 'true' && needs.release-server-ai.result == 'success' }}
337-
env:
338-
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
339-
TAG_NAME: ${{ needs.release-please.outputs.package-server-ai-tag-name }}
340-
run: >
341-
gh release edit "$TAG_NAME"
342-
--repo ${{ github.repository }}
343-
--draft=false
344-
345-
- name: Publish server-ai-langchain release
346-
if: ${{ needs.release-please.outputs.package-server-ai-langchain-released == 'true' && needs.release-server-ai-langchain.result == 'success' }}
347-
env:
348-
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
349-
TAG_NAME: ${{ needs.release-please.outputs.package-server-ai-langchain-tag-name }}
350-
run: >
351-
gh release edit "$TAG_NAME"
352-
--repo ${{ github.repository }}
353-
--draft=false
354-
355-
- name: Publish server-ai-openai release
356-
if: ${{ needs.release-please.outputs.package-server-ai-openai-released == 'true' && needs.release-server-ai-openai.result == 'success' }}
357-
env:
358-
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
359-
TAG_NAME: ${{ needs.release-please.outputs.package-server-ai-openai-tag-name }}
360-
run: >
361-
gh release edit "$TAG_NAME"
362-
--repo ${{ github.repository }}
363-
--draft=false
364-
365-
- name: Publish server-ai-optimization release
366-
if: ${{ needs.release-please.outputs.package-server-ai-optimization-released == 'true' && needs.release-server-ai-optimization.result == 'success' }}
367-
env:
368-
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
369-
TAG_NAME: ${{ needs.release-please.outputs.package-server-ai-optimization-tag-name }}
370-
run: >
371-
gh release edit "$TAG_NAME"
372-
--repo ${{ github.repository }}
373-
--draft=false

‎release-please-config.json‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
"versioning": "default",
88
"bump-minor-pre-major": true,
99
"include-v-in-tag": false,
10-
"draft": true,
1110
"force-tag-creation": true,
1211
"extra-files": [
1312
"src/ldai/__init__.py",
@@ -20,7 +19,6 @@
2019
"versioning": "default",
2120
"bump-minor-pre-major": true,
2221
"include-v-in-tag": false,
23-
"draft": true,
2422
"force-tag-creation": true,
2523
"extra-files": [
2624
"src/ldai_langchain/__init__.py"
@@ -32,7 +30,6 @@
3230
"versioning": "default",
3331
"bump-minor-pre-major": true,
3432
"include-v-in-tag": false,
35-
"draft": true,
3633
"force-tag-creation": true,
3734
"extra-files": [
3835
"src/ldai_openai/__init__.py"
@@ -44,7 +41,6 @@
4441
"versioning": "default",
4542
"bump-minor-pre-major": true,
4643
"include-v-in-tag": false,
47-
"draft": true,
4844
"force-tag-creation": true,
4945
"extra-files": [
5046
"src/ldai_optimization/__init__.py"

0 commit comments

Comments
 (0)