lint, cursor feedback

Author: andrewklatzke

packages/optimization/src/ldai_optimization/client.py

@@ -10,7 +10,6 @@
 from typing import Any, Dict, List, Literal, Optional, Union
 
 from coolname import generate_slug
-
 from ldai import AIAgentConfig, AIJudgeConfig, AIJudgeConfigDefault, LDAIClient
 from ldai.models import LDMessage, ModelConfig
 from ldclient import Context
@@ -1366,10 +1365,6 @@ async def optimize_from_config(
             raise ValueError(
                 "LAUNCHDARKLY_API_KEY is not set, so optimize_from_config is not available"
             )
-        if options.auto_commit and not self._has_api_key:
-            raise ValueError(
-                "auto_commit requires LAUNCHDARKLY_API_KEY to be set"
-            )
 
         assert self._api_key is not None
         api_client = LDApiClient(
@@ -1465,11 +1460,10 @@ def _build_options_from_config(
 
         raw_ground_truth: List[str] = config.get("groundTruthResponses") or []
         has_ground_truth = bool(raw_ground_truth)
-        if not judges and not has_ground_truth and options.on_turn is None:
+        if not judges and options.on_turn is None:
             raise ValueError(
-                "The optimization config has no acceptance statements, judges, or ground truth "
-                "responses, and no on_turn callback was provided. At least one is required to "
-                "evaluate optimization results."
+                "The optimization config has no acceptance statements or judges, and no on_turn "
+                "callback was provided. At least one is required to evaluate optimization results."
             )
 
         project_key = options.project_key

packages/optimization/src/ldai_optimization/dataclasses.py

@@ -14,12 +14,12 @@
     Sequence,
     Union,
 )
-from typing_extensions import Protocol
 
 from ldai import AIAgentConfig
 from ldai.models import LDMessage, ModelConfig
 from ldai.tracker import TokenUsage
 from ldclient import Context
+from typing_extensions import Protocol
 
 
 @dataclass

packages/optimization/src/ldai_optimization/prompts.py

@@ -204,7 +204,7 @@ def variation_prompt_acceptance_criteria(
         "## *** ACCEPTANCE CRITERIA (MUST BE MET) ***",
         "The improved configuration MUST produce responses that satisfy ALL of the following criteria.",
         "These criteria are non-negotiable — every generated variation will be evaluated against them.",
-        "All variables must be used in the new instructions."
+        "All variables must be used in the new instructions.",
         "",
     ]
     for key, statement in statements:

packages/optimization/tests/test_client.py

@@ -1949,7 +1949,7 @@ def test_acceptance_statements_and_judges_merged(self):
 
     def test_raises_when_no_judges_no_ground_truth_no_on_turn(self):
         config = dict(_API_CONFIG, acceptanceStatements=[], judges=[])
-        with pytest.raises(ValueError, match="no acceptance statements, judges, or ground truth"):
+        with pytest.raises(ValueError, match="no acceptance statements or judges"):
             self._build(config=config)
 
     def test_ground_truth_responses_alone_does_not_pass_no_criteria_check(self):