fix: success path + add test, cursor feedback

Author: andrewklatzke

packages/optimization/src/ldai_optimization/client.py

@@ -2209,7 +2209,7 @@ async def _run_optimization(
                     optimize_context, iteration
                 )
                 if all_valid:
-                    return self._handle_success(last_ctx, iteration)
+                    return self._handle_success(optimize_context, iteration)
                 # Validation failed — treat as a normal failed attempt.
                 # Use optimize_context (the main iteration) for terminal API events so
                 # the persisted record's completionResponse and userInput stay aligned.

packages/optimization/tests/test_client.py

@@ -1101,6 +1101,24 @@ async def test_on_turn_manual_path_success(self):
         result = await client.optimize_from_options("test-agent", options)
         assert result.completion_response == "Answer."
 
+    async def test_success_result_carries_main_iteration_context_not_validation_context(self):
+        # The main iteration returns "Main answer." but the validation run returns
+        # "Validation answer.". The result should reflect the main iteration so that
+        # completion_response and user_input are consistent with what was POSTed to the API.
+        agent_responses = [
+            OptimizationResponse(output="Main answer."),       # main iteration
+            OptimizationResponse(output="Validation answer."), # validation sample
+        ]
+        handle_agent_call = AsyncMock(side_effect=agent_responses)
+        handle_judge_call = AsyncMock(return_value=OptimizationResponse(output=JUDGE_PASS_RESPONSE))
+        client = _make_client(self.mock_ldai)
+        options = _make_options(
+            handle_agent_call=handle_agent_call,
+            handle_judge_call=handle_judge_call,
+        )
+        result = await client.optimize_from_options("test-agent", options)
+        assert result.completion_response == "Main answer."
+
     async def test_status_update_callback_called_at_each_stage(self):
         statuses = []
         handle_agent_call = AsyncMock(return_value=OptimizationResponse(output="Good answer."))