address PR feedback

Author: jsonbailey

packages/ai-providers/server-ai-langchain/src/ldai_langchain/langchain_runner_factory.py

@@ -1,6 +1,5 @@
 from typing import Any, Optional
 
-from langchain.agents import create_agent as lc_create_agent
 from ldai.models import AIConfigKind
 from ldai.providers import AIProvider, ToolRegistry
 
@@ -46,6 +45,7 @@ def create_agent(self, config: Any, tools: Optional[ToolRegistry] = None) -> Lan
         :param tools: ToolRegistry mapping tool names to callables
         :return: LangChainAgentRunner ready to run the agent
         """
+        from langchain.agents import create_agent as lc_create_agent
         instructions = (config.instructions or '') if hasattr(config, 'instructions') else ''
         llm = create_langchain_model(config)
         lc_tools = build_structured_tools(config, tools or {})

packages/ai-providers/server-ai-langchain/tests/test_langchain_provider.py

@@ -423,7 +423,7 @@ def test_creates_agent_runner_with_instructions_and_tool_definitions(self):
         mock_agent = MagicMock()
         with patch('ldai_langchain.langchain_runner_factory.create_langchain_model') as mock_create, \
              patch('ldai_langchain.langchain_runner_factory.build_structured_tools') as mock_tools, \
-             patch('ldai_langchain.langchain_runner_factory.lc_create_agent', return_value=mock_agent):
+             patch('langchain.agents.create_agent', return_value=mock_agent):
             mock_create.return_value = MagicMock()
             mock_tools.return_value = [MagicMock()]
 
@@ -448,7 +448,7 @@ def test_creates_agent_runner_with_no_tools(self):
         mock_agent = MagicMock()
         with patch('ldai_langchain.langchain_runner_factory.create_langchain_model') as mock_create, \
              patch('ldai_langchain.langchain_runner_factory.build_structured_tools', return_value=[]), \
-             patch('ldai_langchain.langchain_runner_factory.lc_create_agent', return_value=mock_agent):
+             patch('langchain.agents.create_agent', return_value=mock_agent):
             mock_create.return_value = MagicMock()
 
             factory = LangChainRunnerFactory()

packages/ai-providers/server-ai-openai/src/ldai_openai/openai_agent_runner.py

@@ -121,7 +121,7 @@ def _build_agent_tools(self) -> List[Any]:
                 )
                 continue
 
-            def _make_invoker(fn: Any) -> Any:
+            def _make_invoker(fn: Any, tool_name: str) -> Any:
                 async def on_invoke_tool(tool_ctx: ToolContext, args_json: str) -> str:
                     try:
                         args = json.loads(args_json) if args_json else {}
@@ -133,15 +133,15 @@ async def on_invoke_tool(tool_ctx: ToolContext, args_json: str) -> str:
                             res = await res
                         return str(res)
                     except Exception as e:
-                        log.warning(f"Tool '{name}' execution failed: {e}")
+                        log.warning(f"Tool '{tool_name}' execution failed: {e}")
                         return f"Tool execution failed: {e}"
                 return on_invoke_tool
 
             tools.append(FunctionTool(
                 name=name,
                 description=td.get("description", ""),
                 params_json_schema=td.get("parameters", {}),
-                on_invoke_tool=_make_invoker(tool_fn),
+                on_invoke_tool=_make_invoker(tool_fn, name),
             ))
         return tools