Skip to content

Commit d895e64

Browse files
jsonbaileyclaude
andcommitted
fix: Fix CI lint errors and add run_id to provider tests
- Break long tuple lines in client.py to stay under 120 char limit - Add required run_id parameter to LDAIConfigTracker calls in openai and langchain provider tests Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 6237d6c commit d895e64

4 files changed

Lines changed: 18 additions & 4 deletions

File tree

packages/ai-providers/server-ai-langchain/tests/test_langgraph_callback_handler.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ def _make_graph(mock_ld_client: MagicMock, node_key: str = 'root-agent', graph_k
3535
model_name='gpt-4',
3636
provider_name='openai',
3737
context=context,
38+
run_id='test-run-id',
3839
graph_key=graph_key,
3940
)
4041
graph_tracker = AIGraphTracker(
@@ -402,6 +403,7 @@ def test_flush_with_no_graph_key_on_node_tracker():
402403
model_name='gpt-4',
403404
provider_name='openai',
404405
context=context,
406+
run_id='test-run-id',
405407
)
406408
node_config = AIAgentConfig(
407409
key='root-agent',

packages/ai-providers/server-ai-langchain/tests/test_tracking_langgraph.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ def _make_graph(
4545
model_name='gpt-4',
4646
provider_name='openai',
4747
context=context,
48+
run_id='test-run-id',
4849
graph_key=graph_key,
4950
)
5051

@@ -142,6 +143,7 @@ def _make_two_node_graph(mock_ld_client: MagicMock) -> 'AgentGraphDefinition':
142143
model_name='gpt-4',
143144
provider_name='openai',
144145
context=context,
146+
run_id='test-run-id',
145147
graph_key='two-node-graph',
146148
)
147149
child_tracker = LDAIConfigTracker(
@@ -152,6 +154,7 @@ def _make_two_node_graph(mock_ld_client: MagicMock) -> 'AgentGraphDefinition':
152154
model_name='gpt-4',
153155
provider_name='openai',
154156
context=context,
157+
run_id='test-run-id',
155158
graph_key='two-node-graph',
156159
)
157160
graph_tracker = AIGraphTracker(

packages/ai-providers/server-ai-openai/tests/test_tracking_openai_agents.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ def _make_graph(
4040
model_name='gpt-4',
4141
provider_name='openai',
4242
context=context,
43+
run_id='test-run-id',
4344
graph_key=graph_key,
4445
)
4546

@@ -179,6 +180,7 @@ def _make_two_node_graph(mock_ld_client: MagicMock) -> AgentGraphDefinition:
179180
model_name='gpt-4',
180181
provider_name='openai',
181182
context=context,
183+
run_id='test-run-id',
182184
graph_key='two-node-graph',
183185
)
184186
child_tracker = LDAIConfigTracker(
@@ -189,6 +191,7 @@ def _make_two_node_graph(mock_ld_client: MagicMock) -> AgentGraphDefinition:
189191
model_name='gpt-4',
190192
provider_name='openai',
191193
context=context,
194+
run_id='test-run-id',
192195
graph_key='two-node-graph',
193196
)
194197
graph_tracker = AIGraphTracker(

packages/sdk/server-ai/src/ldai/client.py

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,8 @@ def _completion_config(
110110
default: AICompletionConfigDefault,
111111
variables: Optional[Dict[str, Any]] = None,
112112
) -> AICompletionConfig:
113-
model, provider, messages, instructions, tracker, tracker_factory, enabled, judge_configuration, _ = self.__evaluate(
113+
(model, provider, messages, instructions, tracker,
114+
tracker_factory, enabled, judge_configuration, _) = self.__evaluate(
114115
key, context, default.to_dict(), variables
115116
)
116117

@@ -177,7 +178,8 @@ def _judge_config(
177178
default: AIJudgeConfigDefault,
178179
variables: Optional[Dict[str, Any]] = None,
179180
) -> AIJudgeConfig:
180-
model, provider, messages, instructions, tracker, tracker_factory, enabled, judge_configuration, variation = self.__evaluate(
181+
(model, provider, messages, instructions, tracker,
182+
tracker_factory, enabled, judge_configuration, variation) = self.__evaluate(
181183
key, context, default.to_dict(), variables
182184
)
183185

@@ -887,7 +889,10 @@ def tracker_factory() -> LDAIConfigTracker:
887889
if judges:
888890
judge_configuration = JudgeConfiguration(judges=judges)
889891

890-
return model, provider_config, messages, instructions, tracker, tracker_factory, enabled, judge_configuration, variation
892+
return (
893+
model, provider_config, messages, instructions, tracker,
894+
tracker_factory, enabled, judge_configuration, variation,
895+
)
891896

892897
def __evaluate_agent(
893898
self,
@@ -907,7 +912,8 @@ def __evaluate_agent(
907912
:param graph_key: When set, passed to the tracker so all events include ``graphKey``.
908913
:return: Configured AIAgentConfig instance.
909914
"""
910-
model, provider, messages, instructions, tracker, tracker_factory, enabled, judge_configuration, _ = self.__evaluate(
915+
(model, provider, messages, instructions, tracker,
916+
tracker_factory, enabled, judge_configuration, _) = self.__evaluate(
911917
key, context, default.to_dict(), variables, graph_key=graph_key
912918
)
913919

0 commit comments

Comments
 (0)