Skip to content

Commit ff871bf

Browse files
committed
fix: tighten _track_from_metrics_extractor checks
- Drop the inconsistent 'if metrics else None' guard on reported_ms; the next line already dereferences metrics.success unconditionally. - Use 'is not None' for tool_calls so an explicit empty list still triggers tracking (preserves the distinction between 'not tracked' and 'tracked with no calls').
1 parent 4fe7eb5 commit ff871bf

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

packages/sdk/server-ai/src/ldai/tracker.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -280,15 +280,15 @@ def track_duration_of(self, func):
280280
return result
281281

282282
def _track_from_metrics_extractor(self, metrics: Any, elapsed_ms: int) -> None:
283-
reported_ms = getattr(metrics, 'duration_ms', None) if metrics else None
283+
reported_ms = getattr(metrics, 'duration_ms', None)
284284
self.track_duration(reported_ms if reported_ms is not None else elapsed_ms)
285285
if metrics.success:
286286
self.track_success()
287287
else:
288288
self.track_error()
289289
if metrics.usage:
290290
self.track_tokens(metrics.usage)
291-
if getattr(metrics, 'tool_calls', None):
291+
if getattr(metrics, 'tool_calls', None) is not None:
292292
self.track_tool_calls(metrics.tool_calls)
293293

294294
def track_metrics_of(

0 commit comments

Comments
 (0)