Skip to content

Commit 1de1704

Browse files
committed
fix indentation and note that stop should be idempotent
1 parent ed104e7 commit 1de1704

2 files changed

Lines changed: 5 additions & 2 deletions

File tree

lib/ldclient-rb/impl/data_system/fdv2.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -343,8 +343,8 @@ def synchronizer_loop
343343
# Ensure we always set the ready event when exiting
344344
@ready_event.set
345345
@lock.synchronize do
346-
@active_synchronizer&.stop
347-
@active_synchronizer = nil
346+
@active_synchronizer&.stop
347+
@active_synchronizer = nil
348348
end
349349
end
350350
end

lib/ldclient-rb/interfaces/feature_store.rb

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,9 @@ def initialized?
103103
#
104104
# Performs any necessary cleanup to shut down the store when the client is being shut down.
105105
#
106+
# This method should be idempotent - it is safe to call it multiple times, and subsequent
107+
# calls after the first should have no effect.
108+
#
106109
# @return [void]
107110
#
108111
def stop

0 commit comments

Comments
 (0)