Skip to content

fix: Move fdv2 data source builders into public API #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
keelerm84 merged 5 commits into from
Mar 5, 2026
Merged

fix: Move fdv2 data source builders into public API #371

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0e1936f
fix: Move fdv2 data source builders into public API
keelerm84 Mar 4, 2026
260cdd6
Remove silly backwards compatible block
keelerm84 Mar 5, 2026
545c272
fix specs
keelerm84 Mar 5, 2026
21188a3
move common into data system directory
keelerm84 Mar 5, 2026
048d17b
break data_system.rb up into separate files
keelerm84 Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/ldclient-rb/config.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,15 +468,15 @@ def self.default_capacity
# @return [String] "https://sdk.launchdarkly.com"
#
def self.default_base_uri
Impl::DataSystem::PollingDataSourceBuilder::DEFAULT_BASE_URI
Impl::DataSystem::DEFAULT_POLLING_BASE_URI
end

#
# The default value for {#stream_uri}.
# @return [String] "https://stream.launchdarkly.com"
#
def self.default_stream_uri
Impl::DataSystem::StreamingDataSourceBuilder::DEFAULT_BASE_URI
Impl::DataSystem::DEFAULT_STREAMING_BASE_URI
end

#
Expand Down Expand Up @@ -516,7 +516,7 @@ def self.default_read_timeout
# @return [Float] 1
#
def self.default_initial_reconnect_delay
Impl::DataSystem::StreamingDataSourceBuilder::DEFAULT_INITIAL_RECONNECT_DELAY
Impl::DataSystem::DEFAULT_INITIAL_RECONNECT_DELAY
end

#
Expand Down Expand Up @@ -578,7 +578,7 @@ def self.default_offline
# @return [Float] 30
#
def self.default_poll_interval
Impl::DataSystem::PollingDataSourceBuilder::DEFAULT_POLL_INTERVAL
Impl::DataSystem::DEFAULT_POLL_INTERVAL
end

#
Expand Down
Loading