feat: transition to an error state when stream initial connection fails and no initial retry is configured#101
Merged
Merged
Conversation
…ls withouth retry
keelerm84
reviewed
Dec 15, 2025
Contributor
Author
|
@keelerm84 LGTM. I rather go with your approach with less states/errors. Tested on my end and all works as expected. 👍 from me Thx for pitching in! |
kinyoklion
approved these changes
Dec 16, 2025
Contributor
Author
|
@kinyoklion @keelerm84 had to do an extra commit on top for tests assertions. What's the ETA of merging this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR intends to address #100
BEGIN_COMMIT_OVERRIDE
fix: Bump MSRV to 1.83
fix!: Stream will return
Poll::Ready(None)when client has closed streamfix!: Removed
Error::StreamClosedin lieu of returningPoll::Ready(None)fix: Stop connecting if stream fails on initial request without opting into retry
END_COMMIT_OVERRIDE