fix: Bump MSRV to 1.82.0#95
Merged
Merged
Conversation
- Update rust-version in eventsource-client/Cargo.toml from 1.81.0 to 1.82.0 - Update rustup override in CI workflow from 1.81 to 1.82 Co-Authored-By: mkeeler@launchdarkly.com <keelerm84@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: mkeeler@launchdarkly.com <keelerm84@gmail.com>
jsonbailey
approved these changes
Jul 8, 2025
keelerm84
pushed a commit
that referenced
this pull request
Oct 7, 2025
🤖 I have created a release *beep* *boop* --- ## [0.15.1](0.15.0...0.15.1) (2025-10-07) ### Bug Fixes * Bump MSRV to 1.82.0 ([#95](#95)) ([ddf8753](ddf8753)) * Reconnect should use both reconnect and retry_initial for reconnection ([#99](#99)) ([9a91e67](9a91e67)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chore: bump MSRV to 1.82.0
Summary
This PR updates the Minimum Supported Rust Version (MSRV) from various previous versions (1.74.1, 1.74.0, 1.81.0) to 1.82.0 across the LaunchDarkly Rust SDK repositories. The changes include:
rust-versionin Cargo.toml files to specify 1.82.0 as the minimum supported versionrustup override setcommands)The specific files updated vary by repository structure:
Cargo.tomland.github/actions/tooling/action.ymlCargo.tomlfiles and.github/workflows/ci.ymlcontract-tests/Cargo.tomlwhere applicableReview & Testing Checklist for Human
match result { Ok(r) => r, _ => false }toresult.unwrap_or_default()inrust-server-sdk-redis/src/data_store.rs:249should be functionally equivalent, but please verify this doesn't change behavior for error casescargo buildandcargo testlocally with Rust 1.82.0 to ensure no compilation issues beyond what CI catchesRecommended Test Plan:
Diagram
%%{ init : { "theme" : "default" }}%% graph TD subgraph "rust-server-sdk-redis" A1["Cargo.toml<br/>rust-version: 1.74.1 → 1.82.0"]:::major-edit A2[".github/actions/tooling/action.yml<br/>rustup override: 1.74.1 → 1.82.0"]:::major-edit A3["src/data_store.rs<br/>clippy fix: match → unwrap_or_default()"]:::major-edit end subgraph "rust-server-sdk-evaluation" B1["Cargo.toml<br/>rust-version: 1.74.0 → 1.82.0"]:::major-edit B2[".github/actions/tooling/action.yml<br/>rustup override: 1.74.0 → 1.82.0"]:::major-edit end subgraph "rust-eventsource-client" C1["eventsource-client/Cargo.toml<br/>rust-version: 1.81.0 → 1.82.0"]:::major-edit C2[".github/workflows/ci.yml<br/>rustup override: 1.81 → 1.82"]:::major-edit end subgraph "rust-server-sdk" D1["launchdarkly-server-sdk/Cargo.toml<br/>rust-version: 1.81.0 → 1.82.0"]:::major-edit D2["contract-tests/Cargo.toml<br/>rust-version: 1.81.0 → 1.82.0"]:::major-edit D3[".github/workflows/ci.yml<br/>rustup override: 1.81 → 1.82 (2x)"]:::major-edit end A1 --> A2 A2 --> A3 B1 --> B2 C1 --> C2 D1 --> D2 D2 --> D3 subgraph Legend L1[Major Edit]:::major-edit L2[Minor Edit]:::minor-edit L3[Context/No Edit]:::context end classDef major-edit fill:#90EE90 classDef minor-edit fill:#87CEEB classDef context fill:#FFFFFFNotes
manual_unwrap_or_defaultlint suggested the simplification that was applieddevin/sdk-1371/bump-msrvbranch across all four repositories as requested