Skip to content

fix: Bump MSRV to 1.82.0#95

Merged
jsonbailey merged 2 commits into
mainfrom
devin/sdk-1371/bump-msrv
Jul 8, 2025
Merged

fix: Bump MSRV to 1.82.0#95
jsonbailey merged 2 commits into
mainfrom
devin/sdk-1371/bump-msrv

Conversation

@devin-ai-integration
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot commented Jul 8, 2025

chore: bump MSRV to 1.82.0

Summary

This PR updates the Minimum Supported Rust Version (MSRV) from various previous versions (1.74.1, 1.74.0, 1.81.0) to 1.82.0 across the LaunchDarkly Rust SDK repositories. The changes include:

  • Updated rust-version in Cargo.toml files to specify 1.82.0 as the minimum supported version
  • Updated GitHub Actions workflows to use Rust 1.82.0 in CI builds (rustup override set commands)
  • Fixed a clippy lint error in rust-server-sdk-redis that emerged due to stricter linting in newer Rust versions

The specific files updated vary by repository structure:

  • Standard crates: Updated main Cargo.toml and .github/actions/tooling/action.yml
  • Workspace crates: Updated member crate Cargo.toml files and .github/workflows/ci.yml
  • Contract tests: Updated separate contract-tests/Cargo.toml where applicable

Review & Testing Checklist for Human

⚠️ IMPORTANT: This PR has moderate risk due to MSRV changes and untested clippy fixes.

  • Verify clippy fix correctness: The change from match result { Ok(r) => r, _ => false } to result.unwrap_or_default() in rust-server-sdk-redis/src/data_store.rs:249 should be functionally equivalent, but please verify this doesn't change behavior for error cases
  • Test local builds: Run cargo build and cargo test locally with Rust 1.82.0 to ensure no compilation issues beyond what CI catches
  • Validate MSRV compliance: Confirm that the codebase actually compiles and works correctly with Rust 1.82.0 (not just newer versions)
  • Check dependency compatibility: Ensure all dependencies are compatible with Rust 1.82.0 minimum version
  • Review CI workflow changes: Verify that all GitHub Actions workflows correctly use the new Rust version and that builds pass

Recommended Test Plan:

  1. Install Rust 1.82.0 locally and test building each repository
  2. Run full test suites to ensure no regressions
  3. Verify that users with Rust 1.82.0 can successfully use the SDKs

Diagram

%%{ init : { "theme" : "default" }}%%
graph TD
    subgraph "rust-server-sdk-redis"
        A1["Cargo.toml<br/>rust-version: 1.74.1 → 1.82.0"]:::major-edit
        A2[".github/actions/tooling/action.yml<br/>rustup override: 1.74.1 → 1.82.0"]:::major-edit
        A3["src/data_store.rs<br/>clippy fix: match → unwrap_or_default()"]:::major-edit
    end
    
    subgraph "rust-server-sdk-evaluation"
        B1["Cargo.toml<br/>rust-version: 1.74.0 → 1.82.0"]:::major-edit
        B2[".github/actions/tooling/action.yml<br/>rustup override: 1.74.0 → 1.82.0"]:::major-edit
    end
    
    subgraph "rust-eventsource-client"
        C1["eventsource-client/Cargo.toml<br/>rust-version: 1.81.0 → 1.82.0"]:::major-edit
        C2[".github/workflows/ci.yml<br/>rustup override: 1.81 → 1.82"]:::major-edit
    end
    
    subgraph "rust-server-sdk"
        D1["launchdarkly-server-sdk/Cargo.toml<br/>rust-version: 1.81.0 → 1.82.0"]:::major-edit
        D2["contract-tests/Cargo.toml<br/>rust-version: 1.81.0 → 1.82.0"]:::major-edit
        D3[".github/workflows/ci.yml<br/>rustup override: 1.81 → 1.82 (2x)"]:::major-edit
    end
    
    A1 --> A2
    A2 --> A3
    B1 --> B2
    C1 --> C2
    D1 --> D2
    D2 --> D3
    
    subgraph Legend
        L1[Major Edit]:::major-edit
        L2[Minor Edit]:::minor-edit
        L3[Context/No Edit]:::context
    end
    
    classDef major-edit fill:#90EE90
    classDef minor-edit fill:#87CEEB
    classDef context fill:#FFFFFF
Loading

Notes

  • Session Info: This work was completed by Devin AI for @keelerm84. Session link: https://app.devin.ai/sessions/61a6d2dcad704db2ae6197fcdbb2f68b
  • Testing Limitation: Local testing was limited due to missing OpenSSL development dependencies in the environment, so validation relies primarily on CI
  • Clippy Fix Context: The clippy error emerged because newer Rust versions have stricter linting rules. The manual_unwrap_or_default lint suggested the simplification that was applied
  • Branch Consistency: All changes were made on the devin/sdk-1371/bump-msrv branch across all four repositories as requested

- Update rust-version in eventsource-client/Cargo.toml from 1.81.0 to 1.82.0
- Update rustup override in CI workflow from 1.81 to 1.82

Co-Authored-By: mkeeler@launchdarkly.com <keelerm84@gmail.com>
@devin-ai-integration devin-ai-integration Bot requested a review from a team as a code owner July 8, 2025 15:01
@devin-ai-integration
Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@devin-ai-integration devin-ai-integration Bot changed the title Bump MSRV to 1.82.0 chore: bump MSRV to 1.82.0 Jul 8, 2025
Co-Authored-By: mkeeler@launchdarkly.com <keelerm84@gmail.com>
@jsonbailey jsonbailey changed the title chore: bump MSRV to 1.82.0 fix: bump MSRV to 1.82.0 Jul 8, 2025
@jsonbailey jsonbailey changed the title fix: bump MSRV to 1.82.0 fix: Bump MSRV to 1.82.0 Jul 8, 2025
@jsonbailey jsonbailey merged commit ddf8753 into main Jul 8, 2025
4 checks passed
@jsonbailey jsonbailey deleted the devin/sdk-1371/bump-msrv branch July 8, 2025 15:55
keelerm84 pushed a commit that referenced this pull request Oct 7, 2025
🤖 I have created a release *beep* *boop*
---


##
[0.15.1](0.15.0...0.15.1)
(2025-10-07)


### Bug Fixes

* Bump MSRV to 1.82.0
([#95](#95))
([ddf8753](ddf8753))
* Reconnect should use both reconnect and retry_initial for reconnection
([#99](#99))
([9a91e67](9a91e67))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant