feat: richer Session Replay click descriptions (target text/selector) (#217)

## Summary
- Populate the SR `Click` payload's `clickTextContent` from the tapped
element's visible text (previously the accessibility identifier, usually
empty) and fall back to the class name for `clickSelector`, matching the
web `Click` semantics so the session player shows a meaningful
description.
- Add **temporary** debug logs of the JSON shapes for both the OTel
`click` span and the SR `Click` custom event.

## Note
The debug log lines are intentional and will be removed before release.

## Test plan
- [ ] Tap UI elements; confirm `[Otel Click]` and `[SR Click]` debug
logs show populated `event.text` / `clickTextContent`.
- [ ] Verify the session player renders a non-empty click description.

Made with [Cursor](https://cursor.com)

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Changes what text is recorded for taps (session replay and OTel) and
touches PII-sensitive extraction paths; incorrect filtering could still
leak input or omit useful labels.
> 
> **Overview**
> Improves **Session Replay click descriptions** by filling
`clickTextContent` from the tapped element’s visible text
(`TouchTarget.text` via `extractViewInfo`) and using **accessibility
identifier, else class name** for `clickSelector`, aligned with web
Click semantics.
> 
> **Privacy hardening** in `ViewInfo` so richer text capture does not
leak user input: `UITextField`, `UISearchBar`, and editable `UITextView`
no longer read typed values—only placeholder / accessibility labels.
Descendant title scanning skips text-input views
(`isSensitiveTextInput`) so internal label subviews cannot surface
passwords or queries into click/OTel text.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
66e0bb0. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: abelonogov-ld

Sources/LaunchDarklyObservability/API/Observe.swift

@@ -87,6 +87,11 @@ public protocol TracesApi {
     /// - name The name of the span
     /// - attributes The attributes to record with the span
     func startSpan(name: String, attributes: [String : AttributeValue]) -> Span
+    /// Start a span with an explicit kind.
+    /// - name The name of the span
+    /// - attributes The attributes to record with the span
+    /// - spanKind The kind of the span (defaults to `.client` for most spans)
+    func startSpan(name: String, attributes: [String : AttributeValue], spanKind: SpanKind) -> Span
 }
 
 extension TracesApi {
@@ -97,4 +102,10 @@ extension TracesApi {
     public func startSpan(name: String) -> Span {
         startSpan(name: name, attributes: [:])
     }
+
+    /// Default implementation forwards to ``startSpan(name:attributes:)``, leaving the span kind
+    /// to the implementation's default. Conformers that can honor a specific kind override this.
+    public func startSpan(name: String, attributes: [String : AttributeValue], spanKind: SpanKind) -> Span {
+        startSpan(name: name, attributes: attributes)
+    }
 }

Sources/LaunchDarklyObservability/Plugin/ObservabilityHookExporter.swift

@@ -117,7 +117,7 @@ extension ObservabilityHookExporter: ObservabilityHookExporting {
         attributes[Self.SEMCONV_FEATURE_FLAG_PROVIDER_NAME] = .string(Self.PROVIDER_NAME)
         attributes[Self.SEMCONV_FEATURE_FLAG_CONTEXT_ID] = .string(contextKey)
 
-        let span = traceClient.startSpan(name: Self.FEATURE_FLAG_SPAN_NAME, attributes: attributes)
+        let span = traceClient.startSpan(name: Self.FEATURE_FLAG_SPAN_NAME, attributes: attributes, spanKind: .internal)
 
         if let (_, evictedSpan) = spans.setValue(span, forKey: evaluationId) {
             evictedSpan.end()

Sources/LaunchDarklyObservability/Traces/TraceClient.swift

@@ -31,6 +31,19 @@ final class TraceClient: TracesApi {
         let span = builder.startSpan()
         return span
     }
+
+    /// Starts a span with an explicit kind. Used for the few spans that must not use the
+    /// default `.client` kind (e.g. flag evaluations, which are `.internal`).
+    func startSpan(name: String, attributes: [String : AttributeValue], spanKind: SpanKind) -> any Span {
+        let builder = tracer.spanBuilder(spanName: name)
+        builder.setSpanKind(spanKind: spanKind)
+        attributes.forEach {
+            builder.setAttribute(key: $0.key, value: $0.value)
+        }
+
+        let span = builder.startSpan()
+        return span
+    }
 }
 
 /// Internal method used to set span start date

Sources/LaunchDarklyObservability/Traces/TracerDecorator.swift

@@ -28,6 +28,10 @@ final class TracerDecorator: Tracer {
     func spanBuilder(spanName: String) -> any SpanBuilder {
         let builder = tracer.spanBuilder(spanName: spanName)
 
+        // Spans default to `.client`; callers that need a different kind (e.g. flag
+        // evaluations, which are `.internal`) override this after building.
+        builder.setSpanKind(spanKind: .client)
+
         if let parent = OpenTelemetry.instance.contextProvider.activeSpan {
             builder.setParent(parent)
         }
@@ -68,14 +72,16 @@ extension TracerDecorator: TracesApi {
 
 /// Internal method used to set span start date
 extension Tracer {
-    func startSpan(name: String, attributes: [String : AttributeValue], startTime: Date) -> any Span {
+    func startSpan(name: String, attributes: [String : AttributeValue], startTime: Date, spanKind: SpanKind = .client) -> any Span {
         let builder = spanBuilder(spanName: name)
+        builder.setSpanKind(spanKind: spanKind)
         attributes.forEach {
             builder.setAttribute(key: $0.key, value: $0.value)
         }
 
         builder.setStartTime(time: startTime)
-        
+
+ 
         let span = builder.startSpan()
         return span
     }

Sources/LaunchDarklyObservability/UIInteractions/UInteraction+Span.swift

@@ -20,7 +20,8 @@ extension TouchInteraction {
 
         let span = tracer.startSpan(name: SemanticConvention.clickSpanName,
                                     attributes: attributes,
-                                    startTime: Date(timeIntervalSince1970: startTimestamp))
+                                    startTime: Date(timeIntervalSince1970: startTimestamp),
+                                    spanKind: .client)
         span.end(time: Date(timeIntervalSince1970: timestamp))
     }
 }

Sources/LaunchDarklyObservability/UIInteractions/ViewInfo.swift

@@ -40,13 +40,19 @@ extension UIView {
             return ViewInfo(title: firstNonEmpty(label.text, self.accessibilityLabel), category: "label")
         }
         if let tf = self as? UITextField {
-            return ViewInfo(title: firstNonEmpty(tf.text, tf.placeholder, self.accessibilityLabel), category: "textField")
+            // Never capture an input's typed value (passwords, emails, etc.) - only the
+            // placeholder / accessibility label, which are developer-set, non-sensitive labels.
+            return ViewInfo(title: firstNonEmpty(tf.placeholder, self.accessibilityLabel), category: "textField")
         }
         if let tv = self as? UITextView {
-            return ViewInfo(title: firstNonEmpty(tv.text, self.accessibilityLabel), category: "textView")
+            // Editable text views hold user input; capture only the label. Non-editable text views
+            // are display content (label-like) and safe to read.
+            let title = tv.isEditable ? self.accessibilityLabel : firstNonEmpty(tv.text, self.accessibilityLabel)
+            return ViewInfo(title: title, category: "textView")
         }
         if let sb = self as? UISearchBar {
-            return ViewInfo(title: firstNonEmpty(sb.text, sb.placeholder, self.accessibilityLabel), category: "searchBar")
+            // Never capture the typed search query - only the placeholder / accessibility label.
+            return ViewInfo(title: firstNonEmpty(sb.placeholder, self.accessibilityLabel), category: "searchBar")
         }
         if let seg = self as? UISegmentedControl {
             let selected = seg.selectedSegmentIndex
@@ -72,6 +78,10 @@ extension UIView {
 
     // Depth-first search for a sensible text inside subviews (UILabel/UIButton)
     private func firstDescendantTitle() -> String? {
+        // Never read or descend into text-input views. They render typed values through
+        // private label subviews, so scanning descendants would leak user input
+        // (passwords, emails, search queries, etc.) into the captured title.
+        if isSensitiveTextInput { return nil }
         if let label = self as? UILabel, let t = cleaned(label.text) { return t }
         if let btn = self as? UIButton {
             return firstNonEmpty(btn.titleLabel?.text, btn.currentTitle, btn.title(for: .normal), btn.attributedTitle(for: .normal)?.string)
@@ -82,6 +92,15 @@ extension UIView {
         return nil
     }
 
+    // Views that hold user-typed input. Their values must never be captured, and we must
+    // not descend into them since their text is rendered via internal subviews.
+    private var isSensitiveTextInput: Bool {
+        if self is UITextField { return true }
+        if self is UISearchBar { return true }
+        if let textView = self as? UITextView { return textView.isEditable }
+        return false
+    }
+
     private func allSegmentTitles(_ seg: UISegmentedControl) -> String? {
         guard seg.numberOfSegments > 0 else { return nil }
         let titles = (0..<seg.numberOfSegments)

Sources/LaunchDarklySessionReplay/Exporter/RRWebEventGenerator.swift

@@ -228,10 +228,15 @@ actor RRWebEventGenerator {
     func clickEvent(interaction: TouchInteraction) -> Event? {
         guard case .touchDown = interaction.kind else { return nil }
 
+        // Mirror the web `Click` payload (`highlight-run` ClickListener):
+        // - clickTarget: element identifier (web: full CSS selector path; iOS analog: class name)
+        // - clickTextContent: the element's visible text (web: `target.textContent`)
+        // - clickSelector: simple selector (web: `#id` else tag; iOS analog: a11y id else class name)
+        let target = interaction.target
         let eventData = CustomEventData(tag: .click, payload: ClickPayload(
-            clickTarget: interaction.target?.className ?? "",
-            clickTextContent: interaction.target?.accessibilityIdentifier ?? "",
-            clickSelector: interaction.target?.accessibilityIdentifier ?? "view"))
+            clickTarget: target?.className ?? "",
+            clickTextContent: target?.text ?? "",
+            clickSelector: target?.accessibilityIdentifier ?? target?.className ?? "view"))
         let event = Event(type: .Custom,
                           data: AnyEventData(eventData),
                           timestamp: interaction.timestamp,