Rebuild image when wrapper VERSION changes#15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VERSIONand forces image rebuild when that value changes./opt/codex-yolo-versionso stale images are detected.Problem
Previously, image rebuild decisions only considered image presence, explicit rebuild flags, and Codex CLI version mismatch. If wrapper scripts changed (including
VERSIONupdates) but Codex CLI version stayed the same, old images could persist old runtime behavior.Solution
ARG CODEX_YOLO_WRAPPER_VERSIONin.codex_yolo.Dockerfileand persisted it to/opt/codex-yolo-version.WRAPPER_VERSIONdetection in.codex_yolo.shfrom${SCRIPT_DIR}/VERSION./opt/codex-yolo-versionfrom existing image and computedwrapper_version_mismatch.wrapper_version_mismatchinneed_builddecision.Validation
bash -n .codex_yolo.sh .codex_yolo_entrypoint.sh .codex_yolo_diagnostics.sh install.sh tests/integration_tests.sh./tests/integration_tests.shNotes
CODEX_SKIP_VERSION_CHECK=1, because wrapper version mismatch is independent of Codex CLI npm version checks.