Skip to content
This repository was archived by the owner on Sep 24, 2020. It is now read-only.

added name='number' to the credit input field#30

Open
jpsmith1981 wants to merge 1 commit into
laurihy:masterfrom
jpsmith1981:master
Open

added name='number' to the credit input field#30
jpsmith1981 wants to merge 1 commit into
laurihy:masterfrom
jpsmith1981:master

Conversation

@jpsmith1981

Copy link
Copy Markdown

Fix to make the example show the type of credit card as user inputs it.

There was a change to how Stripe-Form detects values and I do not think the example was ever updated.

@OakBehringer

Copy link
Copy Markdown

This was removed in a different commit...

4586d8b

...because it prevents the card info from being submitted to your servers, keeping you in PCI compliance.

It's a fundamental problem for which I cannot think of a solution. Another place this causes a problem is form validation: if you do not have a name field, it is impossible (I think) to access that field's $invalid state. Right?

Problems.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants