This repository was archived by the owner on Sep 24, 2020. It is now read-only.
Ensuring card length validates properly#66
Open
adamdunkley wants to merge 2 commits into
Open
Conversation
Otherwise this will validate early (for instance card number `4242 4242 4242 4242` will pass luhn validation at `4242 4242 4242 42`
Sorry I haven't minified as I am doing this within github as I am lazy, also don't know what minification settings you use
|
@adamdunkley - run |
|
This also builds the concatenated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise this will validate early (for instance card number
4242 4242 4242 4242will pass luhn validation at4242 4242 4242 42I have not updated the minified code as I don't know what minifier you use/don't know what settings are used.
This could probably have been done in a more generic way.