This repository was archived by the owner on Sep 24, 2020. It is now read-only.
Address Issue #86 making the module usable in "use strict" situations with operations like uglify#90
Open
techguy613 wants to merge 2 commits into
Open
Address Issue #86 making the module usable in "use strict" situations with operations like uglify#90techguy613 wants to merge 2 commits into
techguy613 wants to merge 2 commits into
Conversation
added 2 commits
September 1, 2015 17:43
…out issue (make sure used variables and functions are defined with var) - This addresses open issue laurihy#86 (laurihy#86). Code now works with "use strict". - Added missing semi-colons in function definitions - Incremented version in bower.json
…ask already handles this.
Author
|
Hey @laurihy, I'm wondering if you've had a chance to take a look at this? Please let me know as I think this would be helpful for a lot of folks. Thanks much! |
|
@laurihy please update this module. There are many developers who use this module. I request you to b bit more active. this PR should have been merged long time ago. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for writing this great module! We use it a lot, but ran into issues when moving our build process to use uglify. I've made updates to the code to allow it to work when uglified. Thanks!