Skip to content

MAPS: fix for the build issues by removing sky-test from use in maps#188

Merged
lavenderdotpet merged 2 commits into
mainfrom
lavdotpet-skyfix
Oct 17, 2024
Merged

MAPS: fix for the build issues by removing sky-test from use in maps#188
lavenderdotpet merged 2 commits into
mainfrom
lavdotpet-skyfix

Conversation

@lavenderdotpet

@lavenderdotpet lavenderdotpet commented Oct 16, 2024

Copy link
Copy Markdown
Owner

Description of Changes


replaces sky-test why sky_pando the proper texture which fixes the build issues we have been having

this fix was a part of this pull request but now has been separated to since more changes were requested on that side that was stalling this fix from being applied

Visual Sample


image

Checklist


  • I have read the LibreQuake contribution guidelines
  • I have thoroughly tested my changes to the best of my ability
  • I confirm I have not contributed anything that would impact LibreQuake's licensing and usage
  • This Pull Request fixes a critical issue that should be reviewed and merged as soon as possible

replaces sky-test why sky_pando the proper texture
which fixes the build issues we have been having
@Zungrysoft

Copy link
Copy Markdown
Collaborator

The build is still failing since I merged e1m4 which uses textures from #183. If you review and approve that PR, I can merge it and that will solve this.

@MotoLegacy

Copy link
Copy Markdown
Collaborator

I am confused over the coordination here. Is this PR required or is there another PR that is also resolving this same build failure? Please communicate, thanks

@lavenderdotpet

Copy link
Copy Markdown
Owner Author

The build is still failing since I merged e1m4 which uses textures from #183. If you review and approve that PR, I can merge it and that will solve this.

you aren't using sky-test at all are ya?

@Zungrysoft

Zungrysoft commented Oct 16, 2024

Copy link
Copy Markdown
Collaborator

I accidentally used a texture (a new medieval button texture) from #183 in #182 and I merged it anyway because I assumed the build failure was because of the sky-test thing that this PR is fixing. My mistake.

If we merge #183, which has the texture, the build failure will go away.

@lavenderdotpet

Copy link
Copy Markdown
Owner Author

I am confused over the coordination here. Is this PR required or is there another PR that is also resolving this same build failure? Please communicate, thanks

the one I linked fixed this issue but that pull req has been stalled by a want for more polish on the sky textures

so this pull req is just the fix that removes the sky-test texture from reference in any of the maps

sorry that I wasn't clear
I thought it was

@Zungrysoft

Copy link
Copy Markdown
Collaborator

@lavenderdotpet You'll have to merge master back into this branch to get it to pass the checks now.

@lavenderdotpet

Copy link
Copy Markdown
Owner Author

i think thats correct?

@lavenderdotpet
lavenderdotpet merged commit d99cc81 into main Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants